Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ring notifications #124879

Merged
merged 8 commits into from
Sep 8, 2024
Merged

Conversation

sdb9696
Copy link
Contributor

@sdb9696 sdb9696 commented Aug 29, 2024

Proposed change

The ring integration has been using an api call to get active alerts which it polls every 5 seconds. This service is not being maintained by ring as their native apps all use firebase messaging for push notifications. As a result many issues are created about missing alerts.

This PR migrates to use the push messaging via the RingEventListener.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@sdb9696 sdb9696 marked this pull request as ready for review September 4, 2024 16:36
homeassistant/components/ring/__init__.py Show resolved Hide resolved
homeassistant/components/ring/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/ring/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/ring/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/ring/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/ring/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/ring/strings.json Outdated Show resolved Hide resolved
tests/components/ring/common.py Outdated Show resolved Hide resolved
tests/components/ring/conftest.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 4, 2024 17:08
@home-assistant
Copy link

home-assistant bot commented Sep 4, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@sdb9696
Copy link
Contributor Author

sdb9696 commented Sep 4, 2024

Comments all addressed or with open answer

@sdb9696 sdb9696 marked this pull request as ready for review September 4, 2024 17:52
@sdb9696 sdb9696 mentioned this pull request Sep 8, 2024
19 tasks
@sdb9696
Copy link
Contributor Author

sdb9696 commented Sep 8, 2024

All addressed and #125506 opened which is just adding the event platform and will need to be rebased once this is merged. The new-platform and remove-platform labels need to be removed from this PR.

@sdb9696 sdb9696 requested a review from bdraco September 8, 2024 10:09
@joostlek joostlek merged commit b3d6f88 into home-assistant:dev Sep 8, 2024
29 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
@sdb9696 sdb9696 deleted the fix_ring_notifications branch September 11, 2024 07:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ring intercom integration does not update ding binary sensor
3 participants