-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ring notifications #124879
Merged
Merged
Fix ring notifications #124879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdb9696
force-pushed
the
fix_ring_notifications
branch
2 times, most recently
from
September 3, 2024 13:43
cd1b355
to
5115a42
Compare
sdb9696
force-pushed
the
fix_ring_notifications
branch
from
September 3, 2024 13:54
5115a42
to
77b792c
Compare
8 tasks
sdb9696
force-pushed
the
fix_ring_notifications
branch
from
September 4, 2024 16:18
3eb6716
to
696288a
Compare
joostlek
requested changes
Sep 4, 2024
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
sdb9696
force-pushed
the
fix_ring_notifications
branch
from
September 4, 2024 17:52
5632745
to
f59c94d
Compare
Comments all addressed or with open answer |
bdraco
reviewed
Sep 7, 2024
bdraco
reviewed
Sep 7, 2024
bdraco
reviewed
Sep 7, 2024
bdraco
reviewed
Sep 7, 2024
bdraco
reviewed
Sep 7, 2024
bdraco
reviewed
Sep 7, 2024
bdraco
reviewed
Sep 7, 2024
bdraco
reviewed
Sep 7, 2024
bdraco
reviewed
Sep 7, 2024
bdraco
reviewed
Sep 7, 2024
bdraco
reviewed
Sep 7, 2024
bdraco
reviewed
Sep 7, 2024
bdraco
reviewed
Sep 7, 2024
All addressed and #125506 opened which is just adding the event platform and will need to be rebased once this is merged. The |
bdraco
approved these changes
Sep 8, 2024
joostlek
approved these changes
Sep 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The ring integration has been using an api call to get active alerts which it polls every 5 seconds. This service is not being maintained by ring as their native apps all use firebase messaging for push notifications. As a result many issues are created about missing alerts.
This PR migrates to use the push messaging via the RingEventListener.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: