-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service to set the AC schedule of renault vehicles #125006
Merged
joostlek
merged 7 commits into
home-assistant:dev
from
vhkristof:renault-add-service-to-set-ac-schedule
Sep 20, 2024
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4577df5
Add service to set the AC schedule of renault vehicles
vhkristof f6241ba
Remove executable permission
vhkristof 225022d
Merge remote-tracking branch 'origin/dev' into renault-add-service-to…
vhkristof efb83c6
Applied review comments (use snapshot)
vhkristof 5d800f2
Merge branch 'dev' into renault-add-service-to-set-ac-schedule
vhkristof ba4c00d
Rewrote examples to not use JSON
vhkristof 29666de
Merge branch 'dev' into renault-add-service-to-set-ac-schedule
vhkristof File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
tests/components/renault/fixtures/action.set_ac_schedules.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"data": { | ||
"type": "HvacSchedule", | ||
"id": "guid", | ||
"attributes": { | ||
"schedules": [ | ||
{ | ||
"id": 1, | ||
"activated": true, | ||
"tuesday": { "readyAtTime": "T04:30Z" }, | ||
"wednesday": { "readyAtTime": "T22:30Z" }, | ||
"thursday": { "readyAtTime": "T22:00Z" }, | ||
"friday": { "readyAtTime": "T23:30Z" }, | ||
"saturday": { "readyAtTime": "T18:30Z" }, | ||
"sunday": { "readyAtTime": "T12:45Z" } | ||
} | ||
] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
{ | ||
"data": { | ||
"type": "Car", | ||
"id": "VF1AAAAA555777999", | ||
"attributes": { | ||
"dateTime": "2020-12-24T20:00:00.000Z", | ||
"mode": "scheduled", | ||
"schedules": [ | ||
{ | ||
"id": 1, | ||
"activated": false | ||
}, | ||
{ | ||
"id": 2, | ||
"activated": true, | ||
"wednesday": { "readyAtTime": "T15:15Z" }, | ||
"friday": { "readyAtTime": "T15:15Z" } | ||
}, | ||
{ | ||
"id": 3, | ||
"activated": false, | ||
"monday": { "readyAtTime": "T23:30Z" }, | ||
"tuesday": { "readyAtTime": "T23:30Z" }, | ||
"wednesday": { "readyAtTime": "T23:30Z" }, | ||
"thursday": { "readyAtTime": "T23:30Z" }, | ||
"friday": { "readyAtTime": "T23:30Z" }, | ||
"saturday": { "readyAtTime": "T23:30Z" }, | ||
"sunday": { "readyAtTime": "T23:30Z" } | ||
}, | ||
{ | ||
"id": 4, | ||
"activated": false | ||
}, | ||
{ | ||
"id": 5, | ||
"activated": false | ||
} | ||
] | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could have been a separate bugfix PR 😉 but I think it's ok to leave it in here.