Add login and rewrite access to extended data for solarlog #126024
Merged
+434
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Ernst79, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
dontinelli
changed the title
joostlek
requested changes
Sep 16, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
joostlek
requested changes
Sep 20, 2024
joostlek
requested changes
Sep 20, 2024
Comment on lines
157
to
161
| uid = ( | ||
| f"{entry.entry_id}_time" | ||
| if minor_version == 1 | ||
| else f"{entry.entry_id}_last_updated" | ||
| ) |
There was a problem hiding this comment.
we don't want if statements in the tests
joostlek
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: