Make homekit_controller a local push integration #32213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jc2k
force-pushed
the
homekit_controller_events
branch
from
69d7e56
to
5dfdb24
Compare
Jc2k
force-pushed
the
homekit_controller_events
branch
2 times, most recently
from
9c9ea6b
to
91a1766
Compare
Codecov Report
@@ Coverage Diff @@
## dev #32213 +/- ##
======================================
Coverage ? 94.75%
======================================
Files ? 772
Lines ? 55894
Branches ? 0
======================================
Hits ? 52961
Misses ? 2933
Partials ? 0
Continue to review full report at Codecov.
|
7 tasks
balloob
approved these changes
Feb 26, 2020
Jc2k
force-pushed
the
homekit_controller_events
branch
from
91a1766
to
9802483
Compare
Jc2k
changed the title
| def add_watchable_characteristics(self, characteristics): | ||
| """Add (aid, iid) pairs that we need to poll.""" | ||
| self.watchable_characteristics.extend(characteristics) | ||
| self.hass.add_job(self.pairing.subscribe(characteristics)) |
There was a problem hiding this comment.
If the target is a coroutine, we should use hass.async_create_task instead of hass.async_add_job. The latter is legacy for general use.
Jc2k
added a commit
to Jc2k/home-assistant
that referenced
this pull request
Feb 26, 2020
16 tasks
balloob
pushed a commit
that referenced
this pull request
Feb 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Now that we are using aiohomekit for homekit_controller this PR enables events. This means that accessories can now push their state changes to Home Assistant over an open HomeKit secure session as they happen. In my testing with a Phillips Hue this is near instantaneous.
We added the framework for injecting state changes from events many cycles ago (
HKDevice.process_new_events) so this ends up being quite a modest change now we aren't restrained by a blocking client.Polling still occurs (for now) as not all characteristics support events and it seemed like a good idea to make sure we didn't "miss" any events. There are also edge cases where e.g. a device is unavailable and then becomes available - these might not trigger events. Hybrid push/poll minimizes the impact of these sorts of issues.
NOTE: This is currently behind #32212 in my patch queue. The intention is that it can be reviewed seperately to 5d31f95. I will rebase it and remove the WIP tags after that is merged.Type of change
Additional information
Checklist
black --fast homeassistant tests)If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.The integration reached or maintains the following Integration Quality Scale: