-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten tplink update cycle #87399
Shorten tplink update cycle #87399
Conversation
Hey there @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Simple, short, sweet. Very much appreciated! TP-Link doesn't seem to send updates to local requestors, even when subscribed so this will be a great help. |
Is it possible to expose this value to the end user instead of hard coding it through the integration configuration? I have mine set to 0.5 seconds for months with no impact on memory, processor, responsiveness, or anything negative. Just updates my TP-Link items basically instantaneously. If we let the end user change this it would be much kinder. |
This PR just swaps a value used by a core functionality (i.e., the data update coordinator) so making that configurable is not in the scope of this PR. If such would be wanted, it should be done in the core to allow configuring all integrations and not just a single one. That being said, not making this configurable is a deliberate choice, but I don't know about the details so I cannot really help there. It might have something to do with avoiding the state machine getting too many unnecessary updates to spare the hardware, but who knows :-) |
5 is the minimum allowed. This should work fine now that the connection stays open and it's asyncio. The increase in overhead should be de minimis |
Breaking change
This halves the update cycle from 10 seconds to 5 seconds.
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: