Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten tplink update cycle #87399

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

rytilahti
Copy link
Member

@rytilahti rytilahti commented Feb 4, 2023

Breaking change

This halves the update cycle from 10 seconds to 5 seconds.

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Feb 4, 2023

Hey there @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tplink can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign tplink Removes the current integration label and assignees on the issue, add the integration domain after the command.

@BNolet
Copy link
Contributor

BNolet commented Feb 5, 2023

Simple, short, sweet. Very much appreciated! TP-Link doesn't seem to send updates to local requestors, even when subscribed so this will be a great help.

@awilson133
Copy link

Is it possible to expose this value to the end user instead of hard coding it through the integration configuration? I have mine set to 0.5 seconds for months with no impact on memory, processor, responsiveness, or anything negative. Just updates my TP-Link items basically instantaneously. If we let the end user change this it would be much kinder.

@rytilahti
Copy link
Member Author

This PR just swaps a value used by a core functionality (i.e., the data update coordinator) so making that configurable is not in the scope of this PR. If such would be wanted, it should be done in the core to allow configuring all integrations and not just a single one.

That being said, not making this configurable is a deliberate choice, but I don't know about the details so I cannot really help there. It might have something to do with avoiding the state machine getting too many unnecessary updates to spare the hardware, but who knows :-)

@bdraco
Copy link
Member

bdraco commented Feb 14, 2023

5 is the minimum allowed. This should work fine now that the connection stays open and it's asyncio. The increase in overhead should be de minimis

@bdraco bdraco merged commit 95476f4 into home-assistant:dev Feb 14, 2023
@rytilahti rytilahti deleted the tplink/shorten_update_cycle branch February 14, 2023 16:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kasa integration state update rate
4 participants