Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add romy vacuum integration #93750

Merged
merged 97 commits into from
Jan 31, 2024
Merged

Conversation

xeniter
Copy link
Contributor

@xeniter xeniter commented May 29, 2023

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Add romy vacuum core integration

ROMY vacuum cleaner homepage: https://www.romyrobot.com

PYPI package: https://pypi.org/project/romy/
PYPI package Source: https://github.com/xeniter/romy/releases/tag/0.0.5
Version 0.0.5 containing fix that robot returns initialized true even it can't read sensor value(this is the case when the http interface is still locked): https://github.com/xeniter/romy/compare/0.0.4..0.0.5
0.0.6 contains code review changes from this merge request
Latest Version 0.0.7 contains github workflow to release pypi romy package

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck mentioned this pull request May 29, 2023
11 tasks
@xeniter xeniter force-pushed the romy_pypi_vacuum branch 2 times, most recently from 47aa82d to bb4bb46 Compare May 31, 2023 05:13
@emontnemery emontnemery changed the title Add romy vacuum core integration Add romy vacuum integration May 31, 2023
homeassistant/components/romy/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/romy/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/romy/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/romy/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/romy/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/romy/vacuum.py Outdated Show resolved Hide resolved
homeassistant/components/romy/vacuum.py Outdated Show resolved Hide resolved
homeassistant/components/romy/vacuum.py Outdated Show resolved Hide resolved
homeassistant/components/romy/vacuum.py Outdated Show resolved Hide resolved
homeassistant/components/romy/vacuum.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft May 31, 2023 12:46
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@xeniter xeniter force-pushed the romy_pypi_vacuum branch 4 times, most recently from 827bc56 to 432f51e Compare June 3, 2023 08:30
@xeniter xeniter marked this pull request as ready for review June 3, 2023 09:42
@home-assistant home-assistant bot requested a review from emontnemery June 3, 2023 09:42
@xeniter
Copy link
Contributor Author

xeniter commented Jun 15, 2023

@emontnemery did you take a look at the changes? is everything properly solved?

xeniter and others added 20 commits January 26, 2024 10:48
@xeniter
Copy link
Contributor Author

xeniter commented Jan 26, 2024

@edenhaus #93750 (comment)

what do you like as flow title exactly?

currently:
image

without flow_title set in strings.json:
image

@xeniter xeniter requested a review from edenhaus January 26, 2024 12:25
@xeniter xeniter marked this pull request as ready for review January 26, 2024 12:25
@edenhaus
Copy link
Contributor

@edenhaus #93750 (comment)

what do you like as flow title exactly?

currently: image

without flow_title set in strings.json: image

Sorry, I got confused with the config title vs. the flow title. It is fine

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xeniter 👍

@edenhaus edenhaus merged commit 0c83fd0 into home-assistant:dev Jan 31, 2024
53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants