-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add romy vacuum integration #93750
Add romy vacuum integration #93750
Conversation
47aa82d
to
bb4bb46
Compare
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
827bc56
to
432f51e
Compare
fe6ca4e
to
a3a57a7
Compare
a3a57a7
to
c4e3c1c
Compare
c4e3c1c
to
ebc0024
Compare
@emontnemery did you take a look at the changes? is everything properly solved? |
ebc0024
to
358a723
Compare
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
…th CREATE/ABPORT ENTRY
what do you like as flow title exactly? |
+ adjust test names
c6bf987
to
daaad6f
Compare
Sorry, I got confused with the config title vs. the flow title. It is fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xeniter 👍
Breaking change
Proposed change
Type of change
Additional information
Add romy vacuum core integrationROMY vacuum cleaner homepage: https://www.romyrobot.com
PYPI package: https://pypi.org/project/romy/
PYPI package Source: https://github.com/xeniter/romy/releases/tag/0.0.5
Version 0.0.5 containing fix that robot returns initialized true even it can't read sensor value(this is the case when the http interface is still locked): https://github.com/xeniter/romy/compare/0.0.4..0.0.5
0.0.6 contains code review changes from this merge request
Latest Version 0.0.7 contains github workflow to release pypi romy package
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: