Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename safe mode to recovery mode #18374

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Rename safe mode to recovery mode #18374

merged 2 commits into from
Oct 24, 2023

Conversation

emontnemery
Copy link
Collaborator

Proposed change

Rename safe mode to recovery mode

Needs home-assistant/home-assistant-js-websocket#430

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added Demo Related to frontend demo content Design Related to Home Assistant design gallery labels Oct 24, 2023
piitaya
piitaya previously approved these changes Oct 24, 2023
Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged once websocket lib is merged.

bramkragten
bramkragten previously approved these changes Oct 24, 2023
@bramkragten bramkragten dismissed stale reviews from piitaya and themself via 5f8e76b October 24, 2023 10:40
@github-actions github-actions bot added the Dependencies Pull requests that update a dependency file label Oct 24, 2023
@bramkragten bramkragten merged commit 1fdf609 into dev Oct 24, 2023
13 checks passed
@bramkragten bramkragten deleted the rename_safe_mode branch October 24, 2023 10:56
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Demo Related to frontend demo content Dependencies Pull requests that update a dependency file Design Related to Home Assistant design gallery hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants