-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow GET/SET custom config param in Z-Wave device configuration #22364
base: dev
Are you sure you want to change the base?
Conversation
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-custom-param.ts
Outdated
Show resolved
Hide resolved
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-custom-param.ts
Outdated
Show resolved
Hide resolved
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-custom-param.ts
Outdated
Show resolved
Hide resolved
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-custom-param.ts
Outdated
Show resolved
Hide resolved
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-custom-param.ts
Show resolved
Hide resolved
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-custom-param.ts
Show resolved
Hide resolved
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-node-config.ts
Show resolved
Hide resolved
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not able to test it with core, because I need z-wave server 39.
- What about using
ha-progress-button
or add an additional success message? - Could you maybe add some kind of intro/description what the
Custom configuration
is and what I can use it for? Or a reference to a documenation?
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-custom-param.ts
Show resolved
Hide resolved
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-custom-param.ts
Outdated
Show resolved
Hide resolved
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to set/get any property, but I don't know what parameters to set 😆
LGTM 👍
Proposed change
UI form for custom configuration parameters
Requires home-assistant-libs/zwave-js-server-python#1093
and home-assistant-libs/zwave-js-server-python#1080
Core PR: home-assistant/core#129332
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: