Add sdp m line index to ICE Candidates #22667
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Can you link the associated core PR? |
That's done |
Co-authored-by: Bram Kragten <[email protected]>
|
Hi @bramkragten, since you approved this I have updated the messaging to pass the |
|
@sdb9696 I like that, but the types that are used dont match, the type in frontend has a lot more than the model in the backend. Create a separate type in the frontend that matches the type of the backend. https://developer.mozilla.org/en-US/docs/Web/API/RTCIceCandidate |
Hi @bramkragten, using the same type seems to be consistent with how the RTCConfiguration is being used, i.e. the |
|
The difference there is that for interface RTCConfiguration {
bundlePolicy?: RTCBundlePolicy;
certificates?: RTCCertificate[];
iceCandidatePoolSize?: number;
iceServers?: RTCIceServer[];
iceTransportPolicy?: RTCIceTransportPolicy;
rtcpMuxPolicy?: RTCRtcpMuxPolicy;
}For interface RTCIceCandidate {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCIceCandidate/address) */
readonly address: string | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCIceCandidate/candidate) */
readonly candidate: string;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCIceCandidate/component) */
readonly component: RTCIceComponent | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCIceCandidate/foundation) */
readonly foundation: string | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCIceCandidate/port) */
readonly port: number | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCIceCandidate/priority) */
readonly priority: number | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCIceCandidate/protocol) */
readonly protocol: RTCIceProtocol | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCIceCandidate/relatedAddress) */
readonly relatedAddress: string | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCIceCandidate/relatedPort) */
readonly relatedPort: number | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCIceCandidate/sdpMLineIndex) */
readonly sdpMLineIndex: number | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCIceCandidate/sdpMid) */
readonly sdpMid: string | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCIceCandidate/tcpType) */
readonly tcpType: RTCIceTcpCandidateType | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCIceCandidate/type) */
readonly type: RTCIceCandidateType | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCIceCandidate/usernameFragment) */
readonly usernameFragment: string | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCIceCandidate/toJSON) */
toJSON(): RTCIceCandidateInit;
} |
|
Ah, good point. So I think I'll need to extend the RTCIceCandidate interface. Will check with @edenhaus. |
|
Ok have now more fully implemented
|
Proposed change
Add sdp m line index to WebRTC Ice Candidate.
core PR
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: