Support message coalescing

[bdraco]

yarn link in this folder and then yarn link home-assistant-js-websocket

[bdraco]

That yarn add didn't work. Not sure how to actually test this

[balloob]

yarn link in this folder and then yarn link home-assistant-js-websocket

[balloob]

I think this change is great! I wonder how many race conditions we're going to discover.

[bdraco]

I've got to be doing something dumb but I can't figure this one out

bdraco@Js-MacBook-Pro home-assistant-js-websocket % cd ~/frontend 
bdraco@Js-MacBook-Pro frontend % yarn link home-assistant-js-websocket
Usage Error: Invalid destination; Can't link the project to itself

$ yarn link [-A,--all] [-p,--private] [-r,--relative] <destination>
bdraco@Js-MacBook-Pro frontend % 

[balloob]

Hm, you can just do this I guess:

rm -rf node_moduels/home-assistant-js-websocket
ln -sf ../home-assistant-js-websocket node_moduels/home-assistant-js-websocket

And then it's basically an editable install. Restart webpack.

[bdraco]

rm -rf node_modules/home-assistant-js-websocket
ln -sf ~/home-assistant-js-websocket node_modules/home-assistant-js-websocket

Seems to have worked.

Now I think I have a good test setup 👍

Thanks

[bdraco]

Well spoke too soon

ERROR in ./src/state/disconnect-toast-mixin.ts 3:0-95
Module not found: Error: Can't resolve 'home-assistant-js-websocket' in '/Users/bdraco/frontend/src/state'

[bdraco]

I'm going to do npm run build and copy in the files manually..

[bdraco]

that works.

[bdraco]

everything works and the latency problem from the connection overhead just disappeared with this change

[bdraco]

Testing https://github.com/bdraco/scaletest and I get one message for the event storms it creates

Makes a big difference on performance

[bdraco]

I changed scaletest to do 1000 sensors instead and it no longer overwhelms the system

[bdraco]

And my browser is sitting at 1% cpu instead of maxing out

[bdraco]

Still high cpu with firefox, but much better

[balloob]

We need to add an opt-in message somewhere. Maybe as part of the auth phase ?

[balloob]

Ah snap, we also need it to be backwards compatible. So can't do auth phase.

[bdraco]

diff --git a/lib/messages.ts b/lib/messages.ts
index 57258c1..fd655e4 100644
--- a/lib/messages.ts
+++ b/lib/messages.ts
@@ -4,6 +4,7 @@ export function auth(accessToken: string) {
   return {
     type: "auth",
     access_token: accessToken,
+    features: ["coalesce_messages"],
   };
 }
 

I was thinking something like this but it blows up auth

[bdraco]

Sending supported_features right after auth worked.

Kinda meh on the naming though

[bdraco]

For testing I disabled the dev repo in frontend: to make sure it still works

And I get pages of

2022-08-24 15:28:25.198 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [6429584608] Client exceeded max pending messages [2]: 2048
2022-08-24 15:28:25.199 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [6429584608] Client exceeded max pending messages [2]: 2048
2022-08-24 15:28:25.199 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [6429584608] Client exceeded max pending messages [2]: 2048
2022-08-24 15:28:25.199 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [6429584608] Client exceeded max pending messages [2]: 2048
2022-08-24 15:28:25.199 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [6429584608] Client exceeded max pending messages [2]: 2048
2022-08-24 15:28:25.199 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [6429584608] Client exceeded max pending messages [2]: 2048
2022-08-24 15:28:25.199 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [6429584608] Client exceeded max pending messages [2]: 2048
2022-08-24 15:28:25.199 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [6429584608] Client exceeded max pending messages [2]: 2048
2022-08-24 15:28:25.199 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [6429584608] Client exceeded max pending messages [2]: 2048
2022-08-24 15:28:25.199 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [6429584608] Client exceeded max pending messages [2]: 2048
2022-08-24 15:28:25.201 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [6429584608] Client exceeded max pending messages [2]: 2048
2022-08-24 15:28:25.201 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [6429584608] Client exceeded max pending messages [2]: 2048

[bdraco]

Here is the after

[balloob]

We should limit sending supported features based on the HA version that we get back. We can access the version string on the socket. https://github.com/home-assistant/home-assistant-js-websocket/blob/master/lib/socket.ts#L20

[balloob]

Otherwise people get warnings in their logs on older HA versions.

[bdraco]

Doesn't it already do that?

https://github.com/home-assistant/home-assistant-js-websocket/pull/306/files#diff-f0e64910289a49966c99ceadaa5637404e3439ec0812a4bdb7003fe1e5a33d1cR116

[balloob]

oops missed that.

[bdraco]

Retesting looks good 👍

[zachowj]

Not sure if there is a standard enforcement, but you're using snake case where the existing code base is using camel case.

[bdraco]

Not sure if there is a standard enforcement, but you're using snake case where the existing code base is using camel case.

That's what happens when you write more python 😄

Adjusted