Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of Android TV Remote #28620

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

tronikos
Copy link
Member

Proposed change

  • Add alternatives for launching YouTube
  • Mention the integration doesn't work with Fire TV devices since they are missing a necessary Google service.
  • Add YAML in the collapsible heading since again a couple of users on reddit missed it. Hopefully others can find it by searching for YAML in this page. An alternative would be to stop collapsing it but the YAML code is rather long.
  • Add known issues and suggestions to resolve them.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added the current This PR goes into the current branch label Aug 18, 2023
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor style related comments

source/_integrations/androidtv_remote.markdown Outdated Show resolved Hide resolved
source/_integrations/androidtv_remote.markdown Outdated Show resolved Hide resolved
source/_integrations/androidtv_remote.markdown Outdated Show resolved Hide resolved
source/_integrations/androidtv_remote.markdown Outdated Show resolved Hide resolved
source/_integrations/androidtv_remote.markdown Outdated Show resolved Hide resolved
source/_integrations/androidtv_remote.markdown Outdated Show resolved Hide resolved
source/_integrations/androidtv_remote.markdown Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 18, 2023 07:58
@tronikos tronikos marked this pull request as ready for review August 18, 2023 08:39
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tronikos 👍

@c0ffeeca7 c0ffeeca7 merged commit c8e6478 into home-assistant:current Aug 18, 2023
6 checks passed
@tronikos tronikos deleted the androidtv_remote branch August 18, 2023 08:42
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
Archived in project
2 participants