Add documentation for new service renault.ac_set_schedules #34520
Conversation
…ant#34193) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…4196) Co-authored-by: Franck Nijhof <[email protected]>
* Clarification for raw tip voltage sensor, add ha category * add comma
…t#34217) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…34218) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…34216) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: TheJulianJES <[email protected]>
Closing quote missing from the template
home-assistant#34244) * Update IMAP docs on use of App passwords and removed Microsoft support * Suggested update Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Tiny tweak --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: c0ffeeca7 <[email protected]>
…e-assistant#34251) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…34250) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#34252) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Link to all entities that is support in group Link to all entities that are currently supported in a group * tiny tweak --------- Co-authored-by: c0ffeeca7 <[email protected]>
…tant#34257) * Cleanup mqtt publish action template option documentation * Missed instance
vhkristof
requested review from
a team,
Danielhiversen,
balloob,
bieniu,
thecode,
chemelli74,
bdraco,
jpbede,
starkillerOG,
epenet,
synesthesiam,
emontnemery,
jbouwh,
farmio,
marvin-w,
marcelveldt,
tronikos and
klaasnicolaas
as code owners
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WalkthroughWalkthroughThe recent changes encompass updates to various documentation files and configuration settings across the Home Assistant platform. These updates include version increments for libraries, enhancements to integration documentation, modifications to action handling, and the introduction of new features. Additionally, several links have been updated to reflect a reorganization of documentation sections, improving navigation and clarity for users. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
vhkristof
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (8)
source/_integrations/tailscale.markdown (1)
41-41: Nitpick: Add a hyphen in "top left corner".Consider adding a hyphen in "top left corner" to improve readability:
-You can find it in the top left corner in the [Tailscale Admin Panel](https://login.tailscale.com/admin/settings/keys) +You can find it in the top-left corner in the [Tailscale Admin Panel](https://login.tailscale.com/admin/settings/keys)Tools
LanguageTool
[uncategorized] ~41-~41: Consider adding a hyphen.
Context: ...ilscale network. You can find it in the top left corner in the [Tailscale Admin Panel](h...(TOP_LEFT_CORNER)
source/_integrations/ollama.markdown (2)
26-27: Experimental feature. Approved with a minor suggestion.The introduction of the new experimental feature that allows the Ollama integration to control devices and entities through the Assist API is approved. However, please consider adding the missing word "with" to the sentence for better clarity:
-The AI is able to provide you information about your devices and control them. +The AI is able to provide you with information about your devices and control them.Tools
LanguageTool
[style] ~26-~26: As a shorter alternative for ‘able to’, consider using “can”.
Context: ...itle="exposed entities page" %}. The AI is able to provide you information about your devi...(BE_ABLE_TO)
[uncategorized] ~26-~26: Possible missing preposition found.
Context: ...page" %}. The AI is able to provide you information about your devices and control them. T...(AI_EN_LECTOR_MISSING_PREPOSITION)
Line range hint
45-69: Valuable information and guidelines. Approved with a minor suggestion.The new section titled "Controlling Home Assistant" provides valuable information and guidelines for users who want to experiment with the new feature. The section's content is clear and well-structured, and the suggestion to use multiple Ollama configurations for handling conversations and controlling Home Assistant separately is a good workaround for the limitations of smaller models.
However, please consider adding the missing comma after "model" in the following sentence for better readability:
-However, you may use multiple Ollama configurations that share the same model but use different prompts: +However, you may use multiple Ollama configurations that share the same model, but use different prompts:Tools
LanguageTool
[uncategorized] ~52-~52: A determiner appears to be missing. Consider inserting it.
Context: ...sage (-1 = no limit, 0 = no retention). Default value is -1. {% endconfiguration_basic...(AI_EN_LECTOR_MISSING_DETERMINER)
[style] ~68-~68: This phrase might be redundant. Consider either removing or replacing the adjective ‘additional’.
Context: ...rsation agent to have a conversation. - Add an additional Ollama integration, using the same model, enab...(ADD_AN_ADDITIONAL)
source/_integrations/renault.markdown (1)
61-93: LGTM! Just a minor suggestion to improve the table formatting.The new action
renault.ac_set_schedulesis well-documented and significantly expands the functionality related to vehicle scheduling, allowing for more comprehensive management of AC settings. The documentation is clear and provides sufficient details for users to understand and utilize the new action effectively.Based on the static analysis hint, please consider adding an extra cell to the table row at line 67 to ensure consistent column count and avoid missing data:
- | `vehicle`| yes | device_id of the vehicle | + | `vehicle`| yes | device_id of the vehicle | |Tools
Markdownlint
67-67: Expected: 4; Actual: 3; Too few cells, row will be missing data
Table column count(MD056, table-column-count)
LanguageTool
[style] ~68-~68: To form a complete sentence, be sure to include a subject or ‘there’.
Context: ...|schedules| yes | Schedule details. Can be a single schedule or a list of sched...(MISSING_IT_THERE)
[style] ~72-~72: To form a complete sentence, be sure to include a subject.
Context: ...ule_example) | Notes: -schedulescan be in the form{'id':1,...}when upda...(MISSING_IT_THERE)
[grammar] ~72-~72: Do not use the singular ‘a’ before the plural noun ‘schedules’.
Context: ...n the form{'id':1,...}when updating a single schedules, or in the form `[{'id':1,...},{'id':2,...(VB_A_JJ_NNS)
source/voice_control/thirteen-usd-voice-remote.markdown (1)
98-98: Consider adding a comma before 'and'.LanguageTool suggests adding a comma before 'and' to separate two independent clauses:
... for Assist to find you're done speaking and it can start processing your command.
While the absence of the comma does not significantly impact the clarity of the instructions, adding it would improve the readability of the sentence.
Apply this diff to add the comma:
- This setting defines how much silence is needed for Assist to find you're done speaking and it can start processing your command. + This setting defines how much silence is needed for Assist to find you're done speaking, and it can start processing your command.Tools
LanguageTool
[uncategorized] ~98-~98: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ... for Assist to find you're done speaking and it can start processing your command. ...(COMMA_COMPOUND_SENTENCE)
source/_integrations/calendar.markdown (1)
Line range hint
160-160: LGTM! But consider adding a note to highlight the change in behavior.The change modifies the condition evaluation logic to display the entity only if it matches all specified conditions. This is a significant change in behavior that users should be made aware of.
Consider adding a note to highlight this change, for example:
{% note %} The condition evaluation logic has been updated in this version. The entity will now be displayed only if it matches all specified conditions. Previously, it was displayed if it matched any condition. {% endnote %}Tools
LanguageTool
[uncategorized] ~145-~145: Use a comma before ‘or’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...ar {% term entity %} are described below or you can read more about [actions](/docs...(COMMA_COMPOUND_SENTENCE)
source/_integrations/homeassistant.markdown (1)
215-215: LGTM! Nit: Consider rephrasing.The change to use the
termsyntax forconfiguration.yamlimproves the formatting consistency and readability of the documentation.To address the style hint from LanguageTool, consider rephrasing:
-If you implement `customize`, `customize_domain`, or `customize_glob`, in your {% term "`configuration.yaml`" %} file, you must make sure it is done inside of `homeassistant:` or it will fail. +If you implement `customize`, `customize_domain`, or `customize_glob`, in your {% term "`configuration.yaml`" %} file, you must make sure it is done inside `homeassistant:` or it will fail.Tools
LanguageTool
[style] ~215-~215: This phrase is redundant. Consider using “inside”.
Context: ... %} file, you must make sure it is done inside ofhomeassistant:or it will fail. {% en...(OUTSIDE_OF)
source/_integrations/matter.markdown (1)
329-330: Approved with a nitpick: The additional context is useful, but consider rephrasing "in future" for consistency.The expanded mention of the Distributed Compliance Ledger (DCL) provides useful context about its current usage by Eve and Nanoleaf for updates, as well as the expectation of broader future adoption. This additional information is valuable for readers.
For consistency with American English, consider rephrasing "in future" to "in the future":
-It is expected that in future, more and more firmware updates become available through the DCL. +It is expected that in the future, more and more firmware updates will become available through the DCL.Tools
LanguageTool
[locale-violation] ~329-~329: The phrase ‘in future’ is British English. Did you mean: “in the future”?
Context: ...to provide updates. It is expected that in future, more and more firmware updates become ...(IN_FUTURE)
|
|
||
| ```text | ||
| https://github.com/home-assistant/operating-system/releases/download/{{site.data.version_data.hassos[variant.key]}}/haos_{{ variant.key }}-{{site.data.version_data.hassos[variant.key]}}.img.xz | ||
| ``` |
There was a problem hiding this comment.
Remove trailing spaces.
Markdownlint reports trailing spaces at line 92. Please remove them for consistency and cleanliness of the document.
Apply this diff to fix the issue:
- ```
+ ```Tools
Markdownlint
92-92: Expected: 0 or 2; Actual: 4
Trailing spaces(MD009, no-trailing-spaces)
|
Closed. Created PR to wrong branch |
Proposed change
This PR adds documentation for the new service that is implemented by home-assistant/core#125006
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.Summary by CodeRabbit
New Features
ruby-lspgem to version0.17.17, potentially introducing new features and improvements.renault.ac_set_schedulesfor updating vehicle air conditioning schedules.Bug Fixes
Documentation
Chores