Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Player Intents #1623

Closed
RoepLuke opened this issue Nov 8, 2023 · 9 comments
Closed

Media Player Intents #1623

RoepLuke opened this issue Nov 8, 2023 · 9 comments

Comments

@RoepLuke
Copy link

RoepLuke commented Nov 8, 2023

I want to control a media player entity with Assist (play, pause, forward, backward, lower volume, higher volume, etc).

When testing I was unable to control a media_player entity that was exposed to Assist.
I also did not find any sentence files for the media_player domain.

I'd be willing to contribute the sentences in english and german. However I assume there are other prerequisites that need to be fullfilled to achieve this.

@tetele
Copy link
Contributor

tetele commented Nov 9, 2023

There are other requisites for it to function, not necessarily prerequisites.

Feel free to go for it, expect multiple rounds of reviews :D And thanks for wanting to contribute!

@skynetua
Copy link
Contributor

skynetua commented Dec 6, 2023

Intents need to be added at first.

https://developers.home-assistant.io/docs/voice/intents/

@sorgfresser
Copy link

sorgfresser commented Dec 7, 2023

If we're talking about adding these intents (for example to the media_player component), what intents would you want in particular? You named a few, but ended with etc. What else did you have in mind?

@skynetua
Copy link
Contributor

skynetua commented Dec 8, 2023

Most of mp control services

@sorgfresser
Copy link

sorgfresser commented Dec 9, 2023

So I wanted to get into home-assistant and started some small pr focusing on volume up and volume down intents at the core repository. Other than the intents in core, is there any requisite besides the intents here @tetele ?

@Ay1tsMe
Copy link

Ay1tsMe commented Dec 10, 2023

I think media player intents should have room specific features similar to the light intents. For example, I should be able to say: "Pause music" or "Play music"
and it will pause/play the music in the same area as the voice satellite if there is a media player configured.

@tetele
Copy link
Contributor

tetele commented Dec 11, 2023

Other than the intents in core, is there any requisite besides the intents here @tetele ?

Nope, that's about it @sorgfresser. Here you have to create sentences, responses and tests. We could do that before the core intents and mark the intent as unsupported, but I think a coordinated effort would do better.

@dontinelli
Copy link
Contributor

With #1967 I think this issue can be closed.

@sorgfresser
Copy link

Right now, there is no "play {songname}" intent. Would this be a nice feature to have? I image it might be a bit tedious because the ASR isn't great and thus songnames might be misunderstood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants