Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new intents for cover, valve, vacuum, media player #1967

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

synesthesiam
Copy link
Contributor

Add basic English sentences for new and updated intents in 2024.3: home-assistant/core#110757

Intents:

  • HassTurnOn and HassTurnOff
    • Open/closes valves (like covers)
  • HassSetPosition (new)
    • Sets cover and valve positions to a number 0-100
  • HassSetVolume (new)
    • Sets media player volume to a number 0-100
  • HassMediaPause (new)
    • Pauses a media player
  • HassMediaUnpause (new)
    • Unpauses a media player
  • HassMediaNext (new)
    • Skips a media player to the next item
  • HassVacuumStart (new)
    • Starts a vacuum
  • HassVacuumReturnToBase (new)
    • Returns a vacuum to base

@home-assistant/language-leaders We have about 2 weeks left before the March release, so plenty of time to add some basic sentences 🙂

@tetele
Copy link
Contributor

tetele commented Feb 20, 2024

I wonder if HassSetVolume and HassSetBrightness aren't just a particularization of a certain attribute, so a generic common intent, HassSet

I will look into the sentences a bit later, when i have a clearer head :D

@synesthesiam synesthesiam merged commit 7edd6ed into main Feb 20, 2024
2 checks passed
@synesthesiam synesthesiam deleted the synesthesiam-20240220-new-intents branch February 20, 2024 18:15
@synesthesiam
Copy link
Contributor Author

Merging so language leaders can get started. We can adjust English sentences with follow-up PRs.

davefx added a commit to davefx/intents that referenced this pull request Feb 20, 2024
davefx added a commit that referenced this pull request Feb 20, 2024
v1k70rk4 added a commit to v1k70rk4/intents that referenced this pull request Feb 21, 2024
…edia player

 [HU] home-assistant#1967 Add new intents for cover, valve, vacuum, media player
v1k70rk4 added a commit that referenced this pull request Feb 21, 2024
…1972)

* [HU] #1967 Add new intents for cover, valve, vacuum, media player
@dontinelli dontinelli mentioned this pull request Feb 22, 2024
luyzfernando08 added a commit that referenced this pull request Feb 23, 2024
…1984)

* [PT-BR] Add new intents for cover, valve, vacuum, media player #1967
schizza pushed a commit to schizza/intents that referenced this pull request Mar 16, 2024
…t#1967)

* Add new intents for cover, valve, vacuum, media player

* Rename files

* Move to rules

* Add tests
schizza pushed a commit to schizza/intents that referenced this pull request Mar 16, 2024
schizza pushed a commit to schizza/intents that referenced this pull request Mar 16, 2024
…edia player (home-assistant#1972)

* [HU] home-assistant#1967 Add new intents for cover, valve, vacuum, media player
schizza pushed a commit to schizza/intents that referenced this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants