[DE] Add Support for further German Sentences for the Light Domain #1458
Conversation
This sentence is supposed to be supported already, but it isn't.
|
@easterapps @mib1185 May I kindly ask for a review on this PR as well? |
|
@kroimon Thanks! May I ask you to merge the PR? I think I can't do it on my own even though you have approved it already. |
There was a problem hiding this comment.
HI @Johnson145
thanks for these additions 👍 just one comment about tests
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
…te_HassClimateGetTemperature sentences
There was a problem hiding this comment.
HI @Johnson145
overall I think this looks pretty well, but would be great we could have this logic also for setting a color. Thx 👍
|
@mib1185 I've just extended the PR to cover similar sentences for changing the color of a light. Looking forward to a final review. |
Johnson145
changed the title
|
@mib1185 Updated the branch one more time based on the |
There was a problem hiding this comment.
Hi @Johnson145
that's correct, this is all within my spare time 😉
This PR looks good, thanks for this 👍
…ome-assistant#1458) * Add German test sentence for light_HassTurnOn This sentence is supposed to be supported already, but it isn't. * Add German test sentences for light domain * Allow shorter Area expansion rules to support recently added test sentences. * Add further (shorter) German sentences for the light domain. * Add further German test sentences for the set light domain. * Modify German sentences for the light domain to pass new tests by making some words optional * Bugfix merge conflict of changed area rule conflicting with new climate_HassClimateGetTemperature sentences * Add more desired German test sentences about changing the color of a light * Extend recognition patterns to support recently added German test sentences about changing the color of a light
No description provided.