-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DE] added 't' option to 'machen' expansion rule #1725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ChrM3r
thanks again for your contribution. This sounds reasonable to me 👍
@ChrM3r there are conflicts, please have a look and resolve them, than we can go ahead and merge it, thx 👍 |
@mib1185 Yep, I solved them. |
Like in #1663 I've added an 't' option to the expansion_rule 'machen' because whisper often understands 'macht'.
In addition to the other PR I've added all tests and this PR only contains one specific change.
ChrM3r