Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE] added 't' option to 'machen' expansion rule #1725

Merged
merged 5 commits into from
Dec 9, 2023

Conversation

ChrM3r
Copy link
Contributor

@ChrM3r ChrM3r commented Dec 5, 2023

Like in #1663 I've added an 't' option to the expansion_rule 'machen' because whisper often understands 'macht'.

In addition to the other PR I've added all tests and this PR only contains one specific change.

ChrM3r

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ChrM3r

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Dec 5, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@ChrM3r ChrM3r changed the title added 't' option to 'machen' expansion rule + test [DE] added 't' option to 'machen' expansion rule + test Dec 8, 2023
Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ChrM3r
thanks again for your contribution. This sounds reasonable to me 👍

@mib1185
Copy link
Contributor

mib1185 commented Dec 9, 2023

@ChrM3r there are conflicts, please have a look and resolve them, than we can go ahead and merge it, thx 👍

@mib1185 mib1185 enabled auto-merge (squash) December 9, 2023 15:04
@mib1185 mib1185 changed the title [DE] added 't' option to 'machen' expansion rule + test [DE] added 't' option to 'machen' expansion rule Dec 9, 2023
@ChrM3r
Copy link
Contributor Author

ChrM3r commented Dec 9, 2023

@mib1185 Yep, I solved them.

@mib1185 mib1185 merged commit fc6ad5f into home-assistant:main Dec 9, 2023
2 checks passed
schizza pushed a commit to schizza/intents that referenced this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants