Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN] Context area aware intents #1785

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

tetele
Copy link
Contributor

@tetele tetele commented Dec 14, 2023

Added the area-aware ability to all action intents, not just light_HassTurnXX ones.

Also optimized the light sentences, as completely optional components in a permutation may result in duplicate matches.

Copy link
Contributor

@TheFes TheFes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it be easier to define <in_here> in _common.yaml as you use it quite some places now.

@tetele
Copy link
Contributor Author

tetele commented Dec 14, 2023

I've thought about it, but decided that it's used in relatively few places at the moment, given the total number of sentences.

If you ask me, there are way too many _common lists and expansion rules, particularly since we have local expansion rules and since I've discussed with @synesthesiam about local lists, which seem like a good idea as well.

@synesthesiam
Copy link
Contributor

This looks good to me. I think we will need to have guidelines (possibly language-specific) about the use of words like "all" and if they affect the current area or the entire house.

I personally think that anything affecting the entire house should be harder to say, like "turn off all the lights in the house", but I'm not familiar enough with other commercial voice assistants to know what's common.

@tetele
Copy link
Contributor Author

tetele commented Jan 4, 2024

I personally think that anything affecting the entire house should be harder to say, like "turn off all the lights in the house"

Well, saying "turn on/off all the lights" won't turn on all of them, just the ones in the area, so we're safe for now. We can tweak the sentences and leave out "all" later if needed.

@tetele tetele merged commit b4ac4d5 into home-assistant:main Jan 4, 2024
2 checks passed
davefx added a commit to davefx/intents that referenced this pull request Jan 26, 2024
davefx added a commit that referenced this pull request Jan 26, 2024
* Improving error messages, making them more polite

* Translating changes from 'Context area aware intents #1785' to Spanish
schizza pushed a commit to schizza/intents that referenced this pull request Mar 16, 2024
Perform actions in the same `area` as the satellite.
schizza pushed a commit to schizza/intents that referenced this pull request Mar 16, 2024
* Improving error messages, making them more polite

* Translating changes from 'Context area aware intents home-assistant#1785' to Spanish
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants