-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EN] Context area aware intents #1785
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't it be easier to define <in_here>
in _common.yaml as you use it quite some places now.
I've thought about it, but decided that it's used in relatively few places at the moment, given the total number of sentences. If you ask me, there are way too many |
da084b0
to
f5d461d
Compare
This looks good to me. I think we will need to have guidelines (possibly language-specific) about the use of words like "all" and if they affect the current area or the entire house. I personally think that anything affecting the entire house should be harder to say, like "turn off all the lights in the house", but I'm not familiar enough with other commercial voice assistants to know what's common. |
Well, saying "turn on/off all the lights" won't turn on all of them, just the ones in the area, so we're safe for now. We can tweak the sentences and leave out "all" later if needed. |
* Improving error messages, making them more polite * Translating changes from 'Context area aware intents #1785' to Spanish
Perform actions in the same `area` as the satellite.
* Improving error messages, making them more polite * Translating changes from 'Context area aware intents home-assistant#1785' to Spanish
Added the area-aware ability to all action intents, not just
light_HassTurnXX
ones.Also optimized the
light
sentences, as completely optional components in a permutation may result in duplicate matches.