[fr] Light intents rework 20231221 #1820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Improvement for readability and maintainability of our intents
le
,la
, etc from expansion ruleslumiere
andlumieres
. We have an expansion rulele
for thatNew sentences
New sentences to turn on, off, and set brightness of all areas.
A few examples
Bug fixes
<ouvre> [<le>]{name}
was defined without context. You were able to "open" lights, or vacuumsname: all
)Breaking changes
We cannot survive with sentences such as "Éteins" or "Allume" to turn off and on lights in an area.
I added back the keyword "Lumière".
If tomorrow, we want to extend area awareness to other domains, we will be stuck.
Here are a few examples of sentences that are turning on lights in a room using area awareness
What is not working anymore is
AllumeAllume iciJLo