Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fr] Light intents rework 20231221 #1820

Merged

Conversation

jlpouffier
Copy link
Contributor

@jlpouffier jlpouffier commented Dec 22, 2023

General Improvement for readability and maintainability of our intents

  • Removed le, la, etc from expansion rules lumiere and lumieres. We have an expansion rule le for that
  • All intents use expansion rules for verbs. So that we are sure the infinitive and imperative forms work
    • Baisse la luminosité ....
    • Baisser la luminosité ....
  • Added a comment in front of all sentences to help the reader and contributor understand at least one match

New sentences

New sentences to turn on, off, and set brightness of all areas.
A few examples

  • Allume le bureau
  • Éteins le bureau
  • Baisse le bureau à 20%
  • Monte le salon à 100%

Bug fixes

  • <ouvre> [<le>]{name} was defined without context. You were able to "open" lights, or vacuums
    • Added cover context
    • Moved to cover file
  • Turning off all lights in the home with missing a slot (name: all)

Breaking changes

We cannot survive with sentences such as "Éteins" or "Allume" to turn off and on lights in an area.
I added back the keyword "Lumière".
If tomorrow, we want to extend area awareness to other domains, we will be stuck.

Here are a few examples of sentences that are turning on lights in a room using area awareness

  • "Allume toutes les lumières ici"
  • "Allume les lumières"
  • "Allume la lumière dans cette pièce"
  • "Allumer la lumière ici"

What is not working anymore is

  • Allume
  • Allume ici

JLo

@jlpouffier jlpouffier changed the title Light intents rework 20231221 [fr] Light intents rework 20231221 Dec 22, 2023
@jlpouffier jlpouffier marked this pull request as ready for review December 22, 2023 09:25
@flexy2dd flexy2dd merged commit 2047d84 into home-assistant:main Dec 22, 2023
2 checks passed
@jlpouffier jlpouffier deleted the light-intents-rework-20231221 branch January 1, 2024 20:47
schizza pushed a commit to schizza/intents that referenced this pull request Mar 16, 2024
General Improvement for readability and maintainability of our intents
* Remove <le> from <lumiere> and <lumieres>
* HassLightSet brightness
* HassLightSet color
* Lights HassTurnOff
* HassTurnOn Lights
* Move cover specific command to covers
* Typo
* Add optional [de]
* New tests

thanks @jlpouffier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants