Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[de] Add area slots for scenes #1830

Merged
merged 5 commits into from
Jan 1, 2024
Merged

[de] Add area slots for scenes #1830

merged 5 commits into from
Jan 1, 2024

Conversation

andreasbrett
Copy link
Contributor

allow activation of area-specific scenes by adding area slots (see #1788)

mib1185
mib1185 requested changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andreasbrett

thanks for this contribution 👍
There are only some small comments from my side.

tests/de/scene_HassTurnOn.yaml Outdated Show resolved Hide resolved
sentences/de/scene_HassTurnOn.yaml Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft December 27, 2023 15:13
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@andreasbrett
Copy link
Contributor Author

Hi @mib1185,
thanks for the comments, fixed both issues.

@mib1185
Copy link
Contributor

mib1185 commented Dec 28, 2023

Hi @andreasbrett
I guess this PR should be Ready for review now (short hint about #1830 (comment))?

@andreasbrett andreasbrett marked this pull request as ready for review January 1, 2024 12:09
@home-assistant home-assistant bot requested a review from mib1185 January 1, 2024 12:09
@mib1185 mib1185 enabled auto-merge (squash) January 1, 2024 22:01
@mib1185 mib1185 merged commit a39eb6a into home-assistant:main Jan 1, 2024
2 checks passed
@andreasbrett andreasbrett deleted the scene_area branch January 2, 2024 10:57
@andreasbrett andreasbrett mentioned this pull request Jan 2, 2024
Closed
schizza pushed a commit to schizza/intents that referenced this pull request Mar 16, 2024
@andreasbrett @schizza
[de] Add area slots for scenes (home-assistant#1830)
9a61c91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easterapps easterapps Awaiting requested review from easterapps easterapps is a code owner

@mib1185 mib1185 Awaiting requested review from mib1185 mib1185 is a code owner

Assignees
No one assigned
Labels
cla-signed lang: de
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreasbrett @mib1185