[FR] TODO improvements 20240101 #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlpouffier
changed the title
flexy2dd
approved these changes
Jan 1, 2024
schizza
pushed a commit
to schizza/intents
that referenced
this pull request
Mar 16, 2024
* Add sentence for HassListAddItem * Add new todo entity on fixtures * New test for HassListAddItem * Small fix on a_le and de_le * Remove useless comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new sentences to add items on a todo list in a natural way.
Sentences include:
Features
Added tests for all that.
Note
What do we do with
HassShoppingListAddItem?Now that all shopping lists are also todo entities, I think we could safely remove this intent completely from our intent collection.
For now, I did not touch it.