Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove area "all" slot for all languages #1857

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Jan 4, 2024

Following #1500
area: all doesn't target all areas but only the area called "all" so it should not be used.

Copy link
Contributor

@TheFes TheFes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for the NL intents

Copy link
Member

@LaStrada LaStrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB is good as well

Copy link
Contributor

@andrejs2 andrejs2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for sl. Thanks @piitaya.

@synesthesiam synesthesiam merged commit 71e996f into main Jan 5, 2024
2 checks passed
@synesthesiam synesthesiam deleted the remove_area_all branch January 5, 2024 17:44
@synesthesiam
Copy link
Contributor

Thanks!

schizza pushed a commit to schizza/intents that referenced this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants