[FR] Remove name all slot for french intents #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piitaya
changed the title
synesthesiam
approved these changes
Jan 4, 2024
schizza
pushed a commit
to schizza/intents
that referenced
this pull request
Mar 16, 2024
* Add domain only slot combination * Remove name: all slot for french intents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow targeting all entities from a domain without setting
name: all(e.g. turning on/off all lights of the house) by addingdomain_onlyslot combination.@synesthesiam Not sure if a core update is required for that so I put this PR in draft 🙂
I also noticed that slot combinations were missing for
HassTurnOff.