Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE] Add binary sensor safety #1926

Merged
merged 7 commits into from
Feb 4, 2024
Merged

[DE] Add binary sensor safety #1926

merged 7 commits into from
Feb 4, 2024

Conversation

steffenrapp
Copy link
Contributor

#1428 got closed so I'm adding the safety states.

@steffenrapp steffenrapp marked this pull request as ready for review February 3, 2024 09:42
Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @steffenrapp
thanks for this contribution, just one comment from my side

sentences/de/binary_sensor_HassGetState.yaml Show resolved Hide resolved
@home-assistant
Copy link

home-assistant bot commented Feb 3, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 3, 2024 18:50
@steffenrapp steffenrapp marked this pull request as ready for review February 3, 2024 21:57
@home-assistant home-assistant bot requested a review from mib1185 February 3, 2024 21:57
@home-assistant home-assistant bot marked this pull request as draft February 3, 2024 22:04
@steffenrapp steffenrapp marked this pull request as ready for review February 3, 2024 22:29
@home-assistant home-assistant bot requested a review from mib1185 February 3, 2024 22:29
@mib1185 mib1185 marked this pull request as draft February 3, 2024 22:46
@steffenrapp steffenrapp marked this pull request as ready for review February 4, 2024 08:59
Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@mib1185 mib1185 merged commit ccd33b7 into home-assistant:main Feb 4, 2024
2 checks passed
@steffenrapp steffenrapp deleted the de-binary-sensor-2 branch February 4, 2024 09:19
schizza pushed a commit to schizza/intents that referenced this pull request Mar 16, 2024
* [DE] Add binary sensor safety

* more combinations

* area

* test plural
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants