-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DE] Add binary sensor light #1931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @steffenrapp
thanks for this ... even sentences like "wie viel Licht ist an?" or "ist irgendwo Licht ausgelöst?" sounds weird to me 🙈
we still need some more test sentences, since we add 15 sentences, but only 12 test sentences ... also they use many expansion rules and optional words.
maybe we should create two new expansion rules:
ist_wurde: "(ist|wurde)"
sind_wurden: "(sind|wurden)"
than replace (ist|wurde)
by <ist_wurde>
and (ist|sind|wurde[n])
by (<ist_wurde>|<sind_wurden>)
... with this the amount of test sentences can be reduced, since we do not need to check all these optionals multiple times
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey @mib1185 thank you for the feedback. I know, not every combination sounds natural. I think if it doesn't do anything wrong it shouldn't be a problem. Many voice assistants understand sentences that are not grammatically correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @steffenrapp 👍 i think this is ok for now
No description provided.