[PL] Add basic weather sentences #1993
Conversation
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
@witold-gren I think the weather responses here are more polished than in #1996, I think we should merge this and just overwrite some other changes where it makes sense. |
@Uriziel01 I could do the weather upgrades from #1996 in here, WDYT? |
I would do it the other way around and migrate changes from here into #1996 as that PR is absolutely enormous and I would like to avoid conflicts as much as possible just to be safe. |
|
@Uriziel01 sure, review comments fixed, waiting for workflow approvals :/ |
| response: 8 °C i pada deszcz | ||
|
|
||
| - sentences: | ||
| - "jaka jest pogoda w Warszawa" |
There was a problem hiding this comment.
The correct sentence should be "jaka jest pogoda w Warszawie"
There was a problem hiding this comment.
I'm not sure you can do automatic declination of entities. This could work with aliases though, but by using default entity names here you match the UI
There was a problem hiding this comment.
Yes, you're right but the future these declensions will be used to create sentences for the ML model. I would prefer it to sound correctly in Polish 😀 check this issue #976
deejay1
requested review from
HepoH3,
gabimarchidan,
tetele,
luyzfernando08,
jlpouffier,
piitaya,
easterapps,
mib1185,
halecivo and
schizza
as code owners
|
@Uriziel01 can you reapprove it ? |
* [PL] Add basic weather sentences * [PL] Minor fixes in wording after review * [PL] Review fixes
Add basic support for fetching weather