Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NL] Avoid HassGetState getting triggered on only name #2027

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

TheFes
Copy link
Contributor

@TheFes TheFes commented Mar 3, 2024

HassGetState was getting triggerend when only the name/alias of an entity was used as input. This was uninted, and fixed with this PR.

@TheFes TheFes merged commit e554c39 into main Mar 3, 2024
2 checks passed
@TheFes TheFes deleted the nl_fix_hassgetstate branch March 3, 2024 12:24
dinhchinh82 added a commit to dinhchinh82/intents that referenced this pull request Mar 4, 2024
* [UK] Add new intents for cover, valve, vacuum, media player (home-assistant#1978)

* [UK] Add new intents for cover, valve, vacuum, media player

* Fixed fixtures

* [DE] Add new intents for cover, valve, vacuum, media player (home-assistant#1970)

* [DE] Implement additions from home-assistant#1970 (home-assistant#1991)

* [CS] Add sentence for turning on/off lights in the satelite area. Added expansion rule for lights in plural/singular (home-assistant#1995)

* added turn on all lights

* fix tests

* add expansion for plural or singular lights

* [RU] add intents for media_player (home-assistant#1994)

* [RO] Fixes and improvements (home-assistant#1989)

* Fix spacing in _common.yaml

* binary_sensor

* Climate

* Cover

* Fan

* homeassistant domain

* Light

* Lock

* Media player

* Scene & script

* List

* [PT-BR] expansion_rules adjustment e new errors (home-assistant#1998)

* [PT-BR] add errors

* [PT-BR] expansion_rules adjustment

* add quotation marks

* remove space

* [DE] Add a few more variations to shopping list add item (home-assistant#1985)

* [Fr] Add new intents for cover, valve, vacuum, media player (home-assistant#1973)

* [Fr] Add new intents for cover, valve, vacuum, media player

I had to exclude the vacuum domain in homeassistant_HassTurnOff and homeassistant_HassTurnOn, not sure about the impact of that change.

* Roll back on test/en/media_player_HassMediaNext.yaml

* Update media_player_HassMediaNext.yaml

* [Fr] HassMediaPause.yaml

Changed response and test of HassMediaPause.yaml
--> replace "Pause" with "Lecture en pause"

* [Fr] Reviewed responses and removed expansion_rules

Removed <volume> and <position> expansion rules
Updated tests accordingly
use <regle>, <ouvre> and <ferme> in sentences

* [Fr] Update HassMediaNext

Update the response: Suivant --> Média suivant
Add an expansion_rule <media> with media types (chanson, film...)

* [Fr] Reviewed verbs in new intents

New expansion rules for handling infinitive form of verbs

In the expansion_rule <lire>, I added a nominal form of verbs (lecture, reprise) as they can be used as orders with media players (For example: "Lecture sur la TV" )

Note: I also sorted the expansion rules <capteur> that was in the questions category

* [Fr] fix HassVacuumReturnToBase verb + response update

Use the expansion_rule <renvoie>
Update responses for HassVacuumStart :
"démarré" --> "Nettoyage démarré
and HassMediaUnpause
"Reprise" --> "Lecture relancée"

* [Fr] adjustments on media_player_Hass...

- sentences/fr/_common: split verbs "lire" and "reprendre". add "média" value in <media> expansion_rule
- sentences/fr/media_player_HassUnpause: add an intent to cover "Reprends/reprendre la lecture sur [...]"
- sentences/fr/media_player_HassSetVolume : Deleted unuseful spaces in intent
- test/fr/media_player_HassMediaUnpause: add a test for covering all intents

* Test all YAML sentence files (home-assistant#2003)

* Warn if a test file is not being tested

* Black

* Isort

* Test all files for which we have YAML

* Remove unused import

* pylint

* Ununsed import.......

* Allow other files in intent foler too (home-assistant#2004)

* Allow other files in intent foler too

* Test sentences dir yoooo

* [ES] Add another sentence to turn on/off all lights in an area (home-assistant#2008)

I think it's also very common to say "Enciende el salón" as a way of turning all the lights of an area by name.
It's even more useful to turn things off.

* [ES] Improve success response for turning on a light (home-assistant#2007)

Lights are "encendidas", not "activadas".
Now voice assistant will say: "Luz de la cocina se ha encendido".

* Add new sentence to set a light to a specific brightness (home-assistant#2006)

Enabling "Enciende la luz de la cocina al 30%".

* Suggested custom sentences for media players (home-assistant#1986)

Add more natural sentences for media player control

* fix

* [FR] Set cover position per area, device class, name + area and area awareness  (home-assistant#2002)

* Work complete, all back into a single file for now (Split Not working)

* Removed position. Useless (I checked how we were handling brightness)

* Small Fix on HassNeverMind to remove a warning.

* Splitting the work into domain files

* Removing unneeded article. Correcting answers for domain light (home-assistant#2009)

* [RO] Fix tests (home-assistant#2015)

* fix common sentence

* fix sentences & tests

* fix sentences

* fix sentences and test

* fix sentences and test

* fix fixture

* fix recognition failed

* fix tests

* [FR] Add excluded domains in homeassistant_HassTurnOn/Off (home-assistant#2005)

* [FR] Add excluded domains in homeassistant_HassTurnOn/Off

I noticed problems on my HA main instance if a script name or alias matches homeassistant_HassTurnOn/Off intents.

This PR aligns with the English setup by excluding the following domains besides cover, vacuum, and valves:
            - binary_sensor
            - lock
            - scene
            - script
            - sensor

* [FR] Fix empty line in homeassistant_HassTurnOn.yaml

* [FR] Add empty line in homeassistant_HassTurnOff.yaml

* [FR] Test after lint has failed

* fix tests

* [FI] Add new intents for cover, valve, vacuum, media_player (home-assistant#1990)

* [FI] Add new intents for cover, valve, vacuum, media_player

* fix recognition fail

* fix recognition fail

* [SL] fixed BS motion (home-assistant#2017)

* [CS] Add person state (home-assistant#1997)

* [CS] Add person state

* spaces

* fix home zone

* Addressed scenarios for home and not_home in CZ language

* fix binnary_sensor

* fix script_TurnOn and MediaNext

* fix fan,light,shoppinglist,todo

* fix lock_hassturnoff

* fix fan&lock

* fix tests and sentences

* fix tests and response

* fix tests and response

* fix cover

* fix tests and response

* fix hm_hturnon

* fix tests and response

* fix hasslightset

* fix person

* fix cover_hassgetstate

* fix homeassitant_getstate

* [de-CH] implement new features (including tests) (home-assistant#2020)

* fix hassTurnOn

* fix sensor

* fix sensor

* update tests

* restore lock

* fix lock

* fix sensor

* -.-

* [SL] added HassSetPosition and valve_HassTurnOn (home-assistant#2021)

* [CS] Add HassSetPosition and sensorHassGetState (home-assistant#2022)

* set position

* sensor

* fix broken lights

* fix entity name conflict with area

* weather

* selected binary sensors

* media player

* [HU]valve_HassSetPosition.yaml and cover_HassSetPosition.yaml files should be split (home-assistant#2024)

* [HU[ valve_HassSetPosition.yaml and cover_HassSetPosition.yaml files should be split

* [SL] cover_HassGetState fix (home-assistant#2025)

* [NL] Avoid HassGetState getting triggered on only name (home-assistant#2027)

* [NL] Remove C or F from weather response (home-assistant#2026)

* [SK] Add vacuum intents (home-assistant#2028)

* [SK] Add vacuum intents

* [SK] Add vacuum intents - fix lng

* [SK] Add setPosition intents (home-assistant#2029)

* [SK] Add vacuum intents

* [SK] Add vacuum intents - fix lng

* [SK] Add setPosition intents

* [SK] Add setVolume intent (home-assistant#2030)

* [SK] Add vacuum intents

* [SK] Add vacuum intents - fix lng

* [SK] Add setPosition intents

* [SK] Add setVolume intent

* [SK] Add MediaNextUnPause (home-assistant#2031)

* prettier fix

---------

Co-authored-by: Oleksandr Kapshuk <[email protected]>
Co-authored-by: Michael <[email protected]>
Co-authored-by: steffenrapp <[email protected]>
Co-authored-by: Vaclav <[email protected]>
Co-authored-by: mitrokun <[email protected]>
Co-authored-by: Tudor Sandu <[email protected]>
Co-authored-by: Luiz Oliveira <[email protected]>
Co-authored-by: Jens Reimann <[email protected]>
Co-authored-by: slegars56 <[email protected]>
Co-authored-by: Paulus Schoutsen <[email protected]>
Co-authored-by: Miguel Camba <[email protected]>
Co-authored-by: OzGav <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: JLo <[email protected]>
Co-authored-by: David Marín <[email protected]>
Co-authored-by: salleq <[email protected]>
Co-authored-by: lightningdhna <[email protected]>
Co-authored-by: Andrej Sersen <[email protected]>
Co-authored-by: dontinelli <[email protected]>
Co-authored-by: RViktor <[email protected]>
Co-authored-by: Martijn van der Pol <[email protected]>
Co-authored-by: LubosKadasi <[email protected]>
schizza pushed a commit to schizza/intents that referenced this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant