[FR] Quick Fix on HassSetVolume: Use expansion rule instead of hardcoded de
#2083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This sentence does not work:
Règle le volume des enceintes sur 50%
But this one does:
Règle le volume de les enceintes sur 50%
Solution
Just like we do for brightness, colors, and cover position, I am now using the expansion rule
<de>
instead of a hardcodedde
here:- "<regle> le volume [<de>] [<le>]{name} [à|sur] {volume:volume_level}<pourcent>"
This allows users to say more natural sentences for media players that are plural:
Règle le volume des enceintes sur 50%
NOTE: I added tests with a plural example to make sure we think about these in the future.