[he] added female pronounce to sentences
#2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
ofirsnb
force-pushed
the
he-female-pronounces
branch
from
3987677
to
945f85d
Compare
leranp
approved these changes
Apr 23, 2024
|
Thank you very much for the (very) quick review! 🙏 After about a year using Assist in English, I want my household to use it as well, but they're not English speakers. So just as heads up 😃 - I'm gonna work on the Hebrew further to add more capabilities (domains and such), my goal for it is to be as close to English as possible. Thanks again and happy holiday :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Hebrew, there are different pronounces when addressing male or female.
So, if my wake-word is "Alexa" (female), I need to speak to her in a female form.
Example for non-Hebrew speakers - the term
Turn Onis different for male (הדלק) and female (הדליקי) in Hebrew.Currently, the Hebrew intents are set to be called in a male only form.
This PR adds female form as well, so when calling "Alexa" for example, the rest of the conversation can be natural.
Note - this PR does not alter the
responses- which will remain in neutral form.Thank you.