Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NL] Fix cover intents for open/close #2205

Merged
merged 4 commits into from
May 31, 2024
Merged

[NL] Fix cover intents for open/close #2205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bdcaf22
Dutch curtain open and close intent dont work
TheFes May 31, 2024
372833e
fix indentation for responses in tests
TheFes May 31, 2024
fef2092
really fix indentation now
TheFes May 31, 2024
bd9c6d1
missed one
TheFes May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sentences/nl/cover_HassTurnOff.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ intents:
- "<zou> [de] garage[ ][deur] ((<dicht> willen | <dicht> kunnen | <dicht>[ ])<doe>|sluiten)"
- "<zou> [de] garage[ ][deur] (kunnen|willen) [<dicht>[ ]<doe>|sluiten]"
response: "cover_device_class"
requires_context:
slots:
device_class: "garage"
domain: "cover"

Expand Down Expand Up @@ -49,7 +49,7 @@ intents:
- "<zou> [de|het] <curtain> <in> <area> (willen|kunnen) [<dicht>[ ]<doe>|sluiten]"
- "<zou> [de|het] <curtain> (willen|kunnen) [<dicht>[ ]<doe>|sluiten] <in> <area>"
response: "cover"
requires_context:
slots:
device_class: "curtain"
domain: "cover"

Expand All @@ -61,7 +61,7 @@ intents:
- "<zou> [de|het] (<blind>|<shutter>|<shade>) <in> <area> (willen|kunnen) [<dicht>[ ]<doe>|sluiten]"
- "<zou> [de|het] (<blind>|<shutter>|<shade>) (willen|kunnen) [<dicht>[ ]<doe>|sluiten] <in> <area>"
response: "cover"
requires_context:
slots:
device_class:
- "blind"
- "shutter"
Expand Down
6 changes: 3 additions & 3 deletions sentences/nl/cover_HassTurnOn.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ intents:
- "<zou> [de] garage[ ][deur] ((<open> willen | <open> kunnen | <open>[ ])<doe>|openen)"
- "<zou> [de] garage[ ][deur] (kunnen|willen) [<open>[ ]<doe>|openen]"
response: "cover_device_class"
requires_context:
slots:
device_class: "garage"
domain: "cover"

Expand Down Expand Up @@ -49,7 +49,7 @@ intents:
- "<zou> [de|het] <curtain> <in> <area> (willen|kunnen) [<open>[ ]<doe>|openen]"
- "<zou> [de|het] <curtain> (willen|kunnen) [<open>[ ]<doe>|openen] <in> <area>"
response: "cover"
requires_context:
slots:
device_class: "curtain"
domain: "cover"

Expand All @@ -61,7 +61,7 @@ intents:
- "<zou> [de|het] (<blind>|<shutter>|<shade>) <in> <area> (willen|kunnen) [<open>[ ]<doe>|openen]"
- "<zou> [de|het] (<blind>|<shutter>|<shade>) (willen|kunnen) [<open>[ ]<doe>|openen] <in> <area>"
response: "cover"
requires_context:
slots:
device_class:
- "blind"
- "shutter"
Expand Down
7 changes: 4 additions & 3 deletions tests/nl/cover_HassTurnOff.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ tests:
context:
domain: cover
device_class: curtain
response: Gesloten

- sentences:
- Doe het rolluik achterdeur omlaag
Expand All @@ -26,6 +27,7 @@ tests:
context:
domain: cover
device_class: shutter
response: Gesloten

- sentences:
- Sluit de garage
Expand All @@ -35,9 +37,10 @@ tests:
- Kun je de garagedeur sluiten?
intent:
name: HassTurnOff
context:
slots:
domain: cover
device_class: garage
response: Garage gesloten

- sentences:
- Sluit het gordijn links in de woonkamer
Expand Down Expand Up @@ -82,7 +85,6 @@ tests:
name: HassTurnOff
slots:
area: Woonkamer
context:
device_class: curtain
domain: cover
response: Gesloten
Expand All @@ -100,7 +102,6 @@ tests:
name: HassTurnOff
slots:
area: Woonkamer
context:
device_class: blind
domain: cover
response: Gesloten
8 changes: 4 additions & 4 deletions tests/nl/cover_HassTurnOn.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ tests:
context:
domain: cover
device_class: shutter
response: Geopend

- sentences:
- Open gordijn links
Expand All @@ -25,6 +26,7 @@ tests:
context:
domain: cover
device_class: curtain
response: Geopend

- sentences:
- Open de garagedeur
Expand All @@ -33,10 +35,10 @@ tests:
- Zou je de garagedeur open willen zetten
intent:
name: HassTurnOn
context:
slots:
domain: cover
device_class: garage
response: geopend
response: Garage geopend

- sentences:
- Open gordijn links in de woonkamer
Expand Down Expand Up @@ -81,7 +83,6 @@ tests:
name: HassTurnOn
slots:
area: Woonkamer
context:
device_class: curtain
domain: cover
response: Geopend
Expand All @@ -99,7 +100,6 @@ tests:
name: HassTurnOn
slots:
area: Woonkamer
context:
device_class: blind
domain: cover
response: Geopend