Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN] Add "1/2" alongside "half" #2253

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

synesthesiam
Copy link
Contributor

@synesthesiam synesthesiam commented Jun 24, 2024

HA cloud transcribes "half" and "1/2" sometimes.

Summary by CodeRabbit

  • New Features

    • Enhanced input recognition in lists to support "1/2" as "half" with a value of 30.
  • Tests

    • Updated test sentences for setting timers in Home Assistant to include fractional and decimal variations:
      • "set a timer for 1/2 a minute"
      • "set a timer for 1 and a 1/2 hours"
      • "set a timer for 1/2 an hour"

Copy link

coderabbitai bot commented Jun 24, 2024

Walkthrough

Walkthrough

The changes introduced involve adding support for interpreting the fraction "1/2" as "half", outputting a value of 30 in list processing. Additionally, test cases for Home Assistant's timer-setting functionality have been updated to include variations of fractional time representations, incorporating both fractions and their decimal equivalents.

Changes

File Change Summary
sentences/en/_common.yaml Added support for input "1/2" with an output value of 30 alongside the existing support for "half".
tests/en/homeassistant_HassStart...yaml Updated test sentences for setting timers to include fractional time representations in different formats (fractions and decimal numbers).

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 1d4de6b and 82a2789.

Files selected for processing (2)
  • sentences/en/_common.yaml (1 hunks)
  • tests/en/homeassistant_HassStartTimer.yaml (3 hunks)
Additional comments not posted (4)
tests/en/homeassistant_HassStartTimer.yaml (3)

31-31: Approved the addition of fractional timer setting.

The test sentence "set a timer for 1/2 a minute" correctly implements the intended functionality to recognize fractional time descriptions.


42-42: Approved the addition of complex fractional timer setting.

The test sentence "set a timer for 1 and a 1/2 hours" is well-formed and extends the existing test coverage to include complex fractional times.


54-54: Approved the addition of another fractional timer setting.

The test sentence "set a timer for 1/2 an hour" correctly extends the functionality to recognize different phrasings of fractional times.

sentences/en/_common.yaml (1)

356-357: Approved the addition of fractional representation in lists.

The inclusion of "1/2" with an output value of 30 is consistent with the existing entry for "half" and meets the PR objectives to handle fractional representations uniformly.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@synesthesiam synesthesiam merged commit 4980b7a into main Jun 24, 2024
2 checks passed
@synesthesiam synesthesiam deleted the synesthesiam-20240624-timer-half-2 branch June 24, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant