Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NL] Align ClimateTemperatureSet with EN #2282

Merged
merged 1 commit into from
Jul 7, 2024
Merged

[NL] Align ClimateTemperatureSet with EN #2282

merged 1 commit into from
Jul 7, 2024

Conversation

TheFes
Copy link
Contributor

@TheFes TheFes commented Jul 7, 2024

  • Use <numeric_value_set>
  • Remove formal sentences like zou je de temperatuur in de woonkamer op 19 graden willen zetten
  • Remove <name> as target, as this isn't added in EN, and doesn't seem to be working in my tests in a production system.

Compared to EN I did add the really short intents like woonkamer 19 graden or temperatuur 19 graden. I didn't make graden optional there to avoid conflicts with other intents.

Summary by CodeRabbit

  • New Features

    • Enhanced natural language processing for setting numeric values and temperature adjustments.
    • Expanded the range of media items recognized by the system.
  • Improvements

    • Refined definitions for volume and position in the NL sentences for better user interaction.
    • Improved sentence patterns for setting temperatures in specific areas, ensuring more accurate and flexible commands.

Copy link

coderabbitai bot commented Jul 7, 2024

Walkthrough

Walkthrough

The recent changes involve refining sentence patterns for setting numeric values and temperature in Dutch language configurations. Adjustments emphasize semantic enhancements and expand the options for media items, alongside refining definitions for volume and position settings.

Changes

Files Change Summary
sentences/nl/_common.yaml Updated semantic rules for numeric values, media items, volume, and position settings.
sentences/nl/climate_HassClimateSetTemperature.yaml Refined sentence patterns for temperature adjustments, emphasizing numeric value settings.
tests/nl/climate_HassClimateSetTemperature.yaml Added semantic variations in sentences related to setting temperatures with new command adjustments.

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 4f0d53a and 0c70287.

Files selected for processing (3)
  • sentences/nl/_common.yaml (1 hunks)
  • sentences/nl/climate_HassClimateSetTemperature.yaml (1 hunks)
  • tests/nl/climate_HassClimateSetTemperature.yaml (1 hunks)
Additional comments not posted (15)
sentences/nl/climate_HassClimateSetTemperature.yaml (4)

6-6: LGTM!

The sentence pattern correctly uses <numeric_value_set> and optional elements.


7-7: LGTM!

The sentence pattern correctly uses <numeric_value_set> and optional elements.


8-8: LGTM!

The sentence pattern correctly uses <numeric_value_set> and optional elements.


9-9: LGTM!

The sentence pattern correctly uses <area>, "temperatuur", and optional elements.

tests/nl/climate_HassClimateSetTemperature.yaml (10)

4-4: LGTM!

The test sentence correctly reflects the new pattern.


5-5: LGTM!

The test sentence correctly reflects the new pattern.


6-6: LGTM!

The test sentence correctly reflects the new pattern.


7-7: LGTM!

The test sentence correctly reflects the new pattern.


8-8: LGTM!

The test sentence correctly reflects the new pattern.


15-15: LGTM!

The test sentence correctly reflects the new pattern.


16-16: LGTM!

The test sentence correctly reflects the new pattern.


17-17: LGTM!

The test sentence correctly reflects the new pattern.


18-18: LGTM!

The test sentence correctly reflects the new pattern.


19-19: LGTM!

The test sentence correctly reflects the new pattern.

sentences/nl/_common.yaml (1)

440-440: LGTM!

The numeric_value_set entity remains unchanged.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@TheFes
Copy link
Contributor Author

TheFes commented Jul 7, 2024

Could you have a look at this one @frenck
Inspired by your PR, I just started at the top of the list to see if everything aligns with EN.

@frenck frenck merged commit 32d0805 into main Jul 7, 2024
2 checks passed
@frenck frenck deleted the nl_temp_set branch July 7, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants