Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE] Add HassGetDate and HassGetTime #2314

Merged
merged 3 commits into from
Jul 13, 2024

Conversation

andreasbrett
Copy link
Contributor

@andreasbrett andreasbrett commented Jul 12, 2024

Added prefix "Es ist" for both GetDate and GetTime responses. Also added the weekday to GetDate responses as @TheFes mentioned in #2309. Sounds much more natural to me and solves the ancient misunderstanding when asking...

  • "Welcher Tag ist heute?"
  • "Es ist der 13. Juli 2024"
  • "Nein, ich meine den Wochentag"
  • "Oh, okay, es ist Freitag"

Summary by CodeRabbit

  • New Features

    • Added German language support for querying the current date and time in Home Assistant.
    • Introduced response templates for the current date and time in German.
  • Tests

    • Added German language test cases for querying the current date and time.

Copy link

coderabbitai bot commented Jul 12, 2024

Walkthrough

Walkthrough

This update introduces German language support for Home Assistant intents HassGetCurrentDate and HassGetCurrentTime, including response templates, user query variations, and test cases. Additionally, it expands the word "welche" in _common.yaml to add "welchen." These changes enable users to ask for and receive the current date and time in German.

Changes

File Path Summary
responses/de/HassGetCurrentDate.yaml Introduces a German response template for the current date.
responses/de/HassGetCurrentTime.yaml Introduces a German response template for the current time.
sentences/de/_common.yaml Expands the word "welche" to include "welchen."
sentences/de/homeassistant_HassGetCurrentDate.yaml Adds German support for HassGetCurrentDate intent with user query variations.
sentences/de/homeassistant_HassGetCurrentTime.yaml Adds German support for HassGetCurrentTime intent with user query variations.
tests/de/homeassistant_HassGetCurrentDate.yaml Introduces German test cases for HassGetCurrentDate.
tests/de/homeassistant_HassGetCurrentTime.yaml Introduces German test cases for HassGetCurrentTime.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 77fd910 and 41715b2.

Files selected for processing (4)
  • sentences/de/homeassistant_HassGetCurrentDate.yaml (1 hunks)
  • sentences/de/homeassistant_HassGetCurrentTime.yaml (1 hunks)
  • tests/de/homeassistant_HassGetCurrentDate.yaml (1 hunks)
  • tests/de/homeassistant_HassGetCurrentTime.yaml (1 hunks)
Files skipped from review as they are similar to previous changes (4)
  • sentences/de/homeassistant_HassGetCurrentDate.yaml
  • sentences/de/homeassistant_HassGetCurrentTime.yaml
  • tests/de/homeassistant_HassGetCurrentDate.yaml
  • tests/de/homeassistant_HassGetCurrentTime.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andreasbrett
many thanks for this, really a great job 👍
I've just two small additions, which we should also add (inlc. test sentence), thx 👍

sentences/de/homeassistant_HassGetCurrentTime.yaml Outdated Show resolved Hide resolved
sentences/de/homeassistant_HassGetCurrentDate.yaml Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft July 13, 2024 08:46
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@andreasbrett
Copy link
Contributor Author

Hi @andreasbrett many thanks for this, really a great job 👍 I've just two small additions, which we should also add (inlc. test sentence), thx 👍

Agreed, these changes make sense.

I noticed that STT (HA cloud in my case) translates the spoken "wie viel uhr ist es" to "wieviel uhr ist es" (see: https://www.korrekturen.de/wortliste/wie_viel.shtml), so I added that variant.

@andreasbrett andreasbrett marked this pull request as ready for review July 13, 2024 10:21
@home-assistant home-assistant bot requested a review from mib1185 July 13, 2024 10:21
Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as always good job, your contributions are always highly appropriated @andreasbrett 👍

@mib1185 mib1185 merged commit a67a1e7 into home-assistant:main Jul 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants