Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch to fix Bluetooth LE advertisement stall (#2535) #2598

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

agners
Copy link
Member

@agners agners commented Jun 15, 2023

On some platforms (it seems to be pronounced on Intel NUC systems) Bluetooth advertisements suddenly stop after a short while. Currently there are work arounds in place to restart the HCI controller to keep receiving the advertisements.

Advertisements have been received fine with Linux 5.15. This change reverts a commit which has been isolated to be the culprit.

Since the commit touches generic Bluetooth code used by all controllers, let's revert the commit for all platforms.

On some platforms (it seems to be pronounced on Intel NUC systems)
Bluetooth advertisements suddenly stop after a short while. Currently
there are work arounds in place to restart the HCI controller to keep
receiving the advertisements.

Advertisements have been received fine with Linux 5.15. This change
reverts a commit which has been isolated to be the culprit.
@agners
Copy link
Member Author

agners commented Jun 15, 2023

Thanks @sairon for finding the actual offending commit!

@agners agners merged commit 47de774 into home-assistant:dev Jun 15, 2023
agners added a commit that referenced this pull request Jun 15, 2023
On some platforms (it seems to be pronounced on Intel NUC systems)
Bluetooth advertisements suddenly stop after a short while. Currently
there are work arounds in place to restart the HCI controller to keep
receiving the advertisements.

Advertisements have been received fine with Linux 5.15. This change
reverts a commit which has been isolated to be the culprit.
agners added a commit to agners/operating-system that referenced this pull request Jun 22, 2023
agners added a commit to agners/operating-system that referenced this pull request Aug 30, 2023
)

Instead of reverting the new hci_sync based BLE scan disable logic
use the fix proposed by Luiz:
https://lore.kernel.org/linux-bluetooth/CABBYNZ+5RMqNVMyYKi+gOVaV+K6k8Z-C37KnfGa=qRUORc3dWg@mail.gmail.com/

This fix avoids BLE stalls just like the revert.
agners added a commit that referenced this pull request Aug 30, 2023
Instead of reverting the new hci_sync based BLE scan disable logic
use the fix proposed by Luiz:
https://lore.kernel.org/linux-bluetooth/CABBYNZ+5RMqNVMyYKi+gOVaV+K6k8Z-C37KnfGa=qRUORc3dWg@mail.gmail.com/

This fix avoids BLE stalls just like the revert.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant