Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numpy install (3.12) #631

Merged
merged 3 commits into from
Oct 8, 2023
Merged

Fix numpy install (3.12) #631

merged 3 commits into from
Oct 8, 2023

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Oct 8, 2023

This should work to get numpy build with Python 3.12.

A bit more involved than usual, but until scikit-build/ninja-python-distributions#220 is resolved, ninja needs to be build from git directly unfortunately.

/CC @frenck

@cdce8p
Copy link
Member Author

cdce8p commented Oct 8, 2023

Example run from my fork: https://github.com/cdce8p/wheels/actions/runs/6444260435

Just not sure how to fix the lint issue:

Error: Dockerfile:17 DL4006 warning: Set the SHELL option -o pipefail
  before RUN with a pipe in it. If you are using /bin/sh in an alpine image
  or if your shell is symlinked to busybox then consider explicitly setting
  your SHELL to /bin/ash, or disable this check

@frenck
Copy link
Member

frenck commented Oct 8, 2023

Pushed up change, that addressed the Hadolint issue. Could you check if it still works as expected?

@cdce8p
Copy link
Member Author

cdce8p commented Oct 8, 2023

Pushed up change, that addressed the Hadolint issue. Could you check if it still works as expected?

Thanks! Looks good AFAICT. The workflow is still running but the first jobs were successful already. I'd say, let's try it.
https://github.com/cdce8p/wheels/actions/runs/6447285222/job/17503378562

@frenck frenck merged commit e22c72d into home-assistant:master Oct 8, 2023
3 of 13 checks passed
@cdce8p cdce8p deleted the fix-numpy-312 branch October 8, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants