-
-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor warning message bug in setProps() #937
Labels
Comments
@thoukydides tsk for spotting this, could you supply the fix as a pull request ? |
Pull request #938 created |
Supereg
added a commit
that referenced
this issue
Apr 13, 2022
Co-authored-by: Andi <[email protected]>
Thanks for reporting and fixes this issue. Version v0.10.1 was just released containing this fix. |
koush
pushed a commit
to koush/HAP-NodeJS
that referenced
this issue
Jun 28, 2022
…mebridge#938) Co-authored-by: Andi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Analysis
The warning message for
props.maxValue
being below the minimum for theformat
is incorrectly usingnumericUpperBound
instead ofnumericLowerBound
on src/lib/Characteristic.ts line 1137:This only affects the warning message. The actual range check is applied correctly.
The equivalent code for
props.minValue
is correct.Expected Behavior
Report the minimum allowed value rather than the maximum, when the minimum limit is exceeded.
Steps To Reproduce
n/a
Logs
Configuration
n/a
Environment
n/a
Process Supervisor
not applicable
Additional Context
No response
The text was updated successfully, but these errors were encountered: