Properly type once #929
Merged
Properly type once #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supereg
previously approved these changes
Jan 26, 2022
Pull Request Test Coverage Report for Build 1780910472
💛 - Coveralls |
Supereg
reviewed
Jan 26, 2022
auto-merge was automatically disabled
February 1, 2022 21:56
Head branch was pushed to by a user without write access
|
@Supereg Thanks! When does it ship so I can update homebridge/homebridge#3072 |
|
Currently, we still have some improvements to the |
koush
pushed a commit
to koush/HAP-NodeJS
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in homebridge/homebridge that using once() required the inner function to explicitly typed while returning any. So no type inference and more importantly potential bugs.
Easiest way to see the effect is on TS playground.