Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate on characteristic value correction when calling setProps #978

Merged
merged 1 commit into from
Oct 16, 2022

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Oct 14, 2022

♻️ Current situation

Value correction was introduced in #902. The PR didn't introduce any test cases and also didn't handle a lot of edge cases (see #902 (comment)).

💡 Proposed solution

This PR iterates on this changes by:

  • Adding test coverage
  • Skipping value correction in certain edge cases.

⚙️ Release Notes

--

➕ Additional Information

Testing

Tests were added to verify that setProps corrects numeric and string based formats if bounds restrictions change.
Tests were added to ensure that there aren't any faulty CHANGE events generated.

Reviewer Nudging

--

CC: @ebaauw

@Supereg Supereg requested a review from ebaauw October 14, 2022 09:13
@github-actions github-actions bot added the fix label Oct 14, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3248795521

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 52.151%

Files with Coverage Reduction New Missed Lines %
src/lib/Characteristic.ts 3 77.48%
Totals Coverage Status
Change from base Build 3248146033: 0.1%
Covered Lines: 5800
Relevant Lines: 10167

💛 - Coveralls

@Supereg Supereg merged commit 51c958d into beta-0.11.0 Oct 16, 2022
@Supereg Supereg deleted the fix/test-cases-set-props branch October 16, 2022 09:40
@Shaquu
Copy link
Contributor

Shaquu commented Oct 16, 2022

@Supereg what is the plan for the release? Anything I can do to help?

@Supereg
Copy link
Member Author

Supereg commented Oct 16, 2022

See v0.11.0. Basically code coverage and advertiser PRs.

@Supereg
Copy link
Member Author

Supereg commented Oct 16, 2022

Any review on the advertiser PRs would be helpful.

@Shaquu
Copy link
Contributor

Shaquu commented Oct 16, 2022

On it

Supereg added a commit that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants