Iterate on characteristic value correction when calling setProps #978
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Value correction was introduced in #902. The PR didn't introduce any test cases and also didn't handle a lot of edge cases (see #902 (comment)).
💡 Proposed solution
This PR iterates on this changes by:
⚙️ Release Notes
--
➕ Additional Information
Testing
Tests were added to verify that setProps corrects numeric and string based formats if bounds restrictions change.
Tests were added to ensure that there aren't any faulty CHANGE events generated.
Reviewer Nudging
--
CC: @ebaauw