Update to Go 1.22 #180
Merged
Update to Go 1.22 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanjohnsontv
requested review from
alice485,
pjberry16 and
guido9j
as code owners
alice485
approved these changes
Jun 4, 2024
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes with this:
kubernetes/apimachinery/pkg/labels no longer return nil with err, it now includes a pointer to a Requirement struct. Tests needed to be updated because they checked for nil.
Updated kubernetes controller test to use valid (but dummy) cert string for CAData as it now validates it. Copied from here: https://github.com/kubernetes/client-go/blob/master/transport/transport_test.go
Uses existing arcade client instead of custom one: https://github.com/homedepot/arcade/tree/master/pkg