-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subheading for "Property command topic" #145
Conversation
To break up the "Property" section another subheading is introduced. Some sentences that only justify but do not clarify are removed. Added the hint that controllers publish to "/set" only with non retained messages.
@@ -295,7 +299,6 @@ homie/kitchen-light/light/power/set ← "true" | |||
``` | |||
|
|||
The device would then turn on the light, and update its `power` state. | |||
This provides pessimistic feedback, which is important for home automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep "pessimistic feedback" in the document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the wording, maybe you can come up with a different approach. I'd rather not have the original sentence, the statement is made without any proof.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
After the device successfully received and processed the command, pessimistic feedback is given by publishing the new state of the property:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As soon as feedback is given (publishing happened), it is neither pessimistic nor optimistic feedback, it is just feedback. The process/procedure itself (publish to prop/set -> processing -> publish to prop) is pessimistic feedback and that isn't conveyed in this sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely correct. Okay let's leave it out. I'll edit my other comment.
Co-Authored-By: davidgraeff <[email protected]>
Co-Authored-By: davidgraeff <[email protected]>
Co-Authored-By: davidgraeff <[email protected]>
Co-Authored-By: davidgraeff <[email protected]>
To break up the "Property" section another subheading is introduced.
Some sentences that only justify but do not clarify are removed.
Added the hint that controllers publish to "/set" only with non retained messages.