Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subheading for "Property command topic" #145

Merged
merged 7 commits into from
Nov 29, 2018
Merged

Conversation

davidgraeff
Copy link
Member

To break up the "Property" section another subheading is introduced.
Some sentences that only justify but do not clarify are removed.
Added the hint that controllers publish to "/set" only with non retained messages.

To break up the "Property" section another subheading is introduced.
Some sentences that only justify but do not clarify are removed.
Added the hint that controllers publish to "/set" only with non retained messages.
convention.md Outdated Show resolved Hide resolved
@@ -295,7 +299,6 @@ homie/kitchen-light/light/power/set ← "true"
```

The device would then turn on the light, and update its `power` state.
This provides pessimistic feedback, which is important for home automation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep "pessimistic feedback" in the document.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the wording, maybe you can come up with a different approach. I'd rather not have the original sentence, the statement is made without any proof.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

After the device successfully received and processed the command, pessimistic feedback is given by publishing the new state of the property:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As soon as feedback is given (publishing happened), it is neither pessimistic nor optimistic feedback, it is just feedback. The process/procedure itself (publish to prop/set -> processing -> publish to prop) is pessimistic feedback and that isn't conveyed in this sentence.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely correct. Okay let's leave it out. I'll edit my other comment.

convention.md Outdated Show resolved Hide resolved
convention.md Outdated Show resolved Hide resolved
convention.md Outdated Show resolved Hide resolved
Thomas Dietrich and others added 2 commits November 29, 2018 11:25
Co-Authored-By: davidgraeff <[email protected]>
Co-Authored-By: davidgraeff <[email protected]>
Co-Authored-By: davidgraeff <[email protected]>
convention.md Outdated Show resolved Hide resolved
convention.md Outdated Show resolved Hide resolved
Thomas Dietrich and others added 2 commits November 29, 2018 19:02
@davidgraeff davidgraeff merged commit ecc7aa4 into develop Nov 29, 2018
@davidgraeff davidgraeff deleted the davidgraeff-patch-2 branch November 29, 2018 18:13
@qoole qoole mentioned this pull request Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants