fix: clean asset url with regex (#886)

Fixes: #878
honeybadger-io · Sep 20, 2022 · 9c0032b · 9c0032b
1 parent c5aff95
commit 9c0032b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/packages/webpack/src/HoneybadgerSourceMapPlugin.js b/packages/webpack/src/HoneybadgerSourceMapPlugin.js
@@ -119,8 +119,9 @@ class HoneybadgerSourceMapPlugin {
 
   getUrlToAsset (sourceFile) {
     if (typeof sourceFile === 'string') {
-      const sep = this.assetsUrl.endsWith('/') ? '' : '/'
-      return `${this.assetsUrl}${sep}${sourceFile}`
+      const sep = '/'
+      const unsanitized = `${this.assetsUrl}${sep}${sourceFile}`
+      return unsanitized.replace(/([^:]\/)\/+/g, '$1')
     }
     return this.assetsUrl(sourceFile)
   }

diff --git a/packages/webpack/test/HoneybadgerSourceMapPlugin.test.js b/packages/webpack/test/HoneybadgerSourceMapPlugin.test.js
@@ -468,6 +468,21 @@ describe(PLUGIN_NAME, function () {
       await plugin.uploadSourceMap(compilation, chunk)
       expect(this.info.calledWith('Uploaded vendor.5190.js.map to Honeybadger API')).to.eq(true)
     })
+
+    it('should build correct assert url', function () {
+      const sourceFile1 = '/js/app.js'
+      const sourceFile2 = 'js/app.js'
+
+      const plugin = new HoneybadgerSourceMapPlugin({ assetsUrl: 'https://example.com' });
+      expect(plugin.assetsUrl).to.eq('https://example.com')
+      expect(plugin.getUrlToAsset(sourceFile1)).to.eq('https://example.com/js/app.js')
+      expect(plugin.getUrlToAsset(sourceFile2)).to.eq('https://example.com/js/app.js')
+
+      plugin.assetsUrl = 'https://example.com/'
+      expect(plugin.assetsUrl).to.eq('https://example.com/')
+      expect(plugin.getUrlToAsset(sourceFile1)).to.eq('https://example.com/js/app.js')
+      expect(plugin.getUrlToAsset(sourceFile2)).to.eq('https://example.com/js/app.js')
+    })
   })
 
   describe('sendDeployNotification', function () {