Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds configurable dev environments for source map upload plugins #1412

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

subzero10
Copy link
Member

@subzero10 subzero10 commented Oct 21, 2024

Status

READY

Description

Adds a configuration source map plugin option developmentEnvironments, similar to what we have for the core plugin. The sole purpose of this option is to be used in order to decide whether source maps should be uploaded or not.

Closes #1408.

TODO

  • Create new developmentEnvironments option
  • Update webpack, rollup and esbuild plugins to use new option
  • Update README.md in rollup, esbuild and webpack plugins
  • Update tests

@subzero10 subzero10 added webpack @honeybadger-io/webpack rollup/vite @honeybadger-io/rollup-plugin esbuild @honeybadger-io/esbuild-plugin labels Oct 21, 2024
@subzero10 subzero10 requested a review from stympy October 21, 2024 06:40
@subzero10 subzero10 self-assigned this Oct 21, 2024
@subzero10 subzero10 merged commit cae080b into master Oct 22, 2024
11 checks passed
@subzero10 subzero10 deleted the configurable-dev-environment-in-plugin-core-1408 branch October 22, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esbuild @honeybadger-io/esbuild-plugin rollup/vite @honeybadger-io/rollup-plugin webpack @honeybadger-io/webpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollup plugin does not upload source maps to staging environments
2 participants