Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: send RequestHandled, JobProcessed and ResponseReceived events to insights #130

Merged
merged 26 commits into from
Sep 17, 2024
Merged

feat: send RequestHandled, JobProcessed and ResponseReceived events to insights #130

merged 26 commits into from
Sep 17, 2024

Conversation

subzero10
Copy link
Member

@subzero10 subzero10 commented Sep 5, 2024 •
edited
Loading

Status

READY

Description

  • Adds a type property in EventPayload to be used for Insights.
  • Adds RequestHandled event.
  • Adds JobProcessed event.
  • Adds ResponseReceived event for outgoing requests/responses.
  • Adds duration to ViewRendered event.
  • Adds requestId in event payload.

rabidpraxis
rabidpraxis reviewed Sep 5, 2024
View reviewed changes
src/Events/ApplicationEvent.php Outdated Show resolved Hide resolved
src/Middleware/AssignRequestId.php Show resolved Hide resolved
@subzero10 subzero10 changed the title feat: send RequestHandled event to insights feat: send RequestHandled and JobProcessed event to insights Sep 9, 2024
@subzero10 subzero10 changed the title feat: send RequestHandled and JobProcessed event to insights feat: send RequestHandled, JobProcessed and ResponseReceived events to insights Sep 14, 2024
rabidpraxis
rabidpraxis approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@rabidpraxis rabidpraxis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the one comment, this looks great! 👍🏻

src/Events/ApplicationEvent.php Outdated Show resolved Hide resolved
@subzero10 subzero10 merged commit 7f68015 into master Sep 17, 2024
11 of 12 checks passed
@github-actions github-actions bot mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabidpraxis rabidpraxis rabidpraxis approved these changes

Assignees

@rabidpraxis rabidpraxis

@subzero10 subzero10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subzero10 @rabidpraxis