Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't use ::set-output #299

Merged
merged 1 commit into from
Apr 8, 2024
Merged

chore: don't use ::set-output #299

merged 1 commit into from
Apr 8, 2024

Conversation

brookesargent
Copy link
Contributor

@brookesargent brookesargent commented Apr 8, 2024

Which problem is this PR solving?

Short description of the changes

Replaces ::set-output with $GITHUB_OUTPUT as documented here: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

How to verify that this has the expected result

I tested the updated syntax in a separate repo and it worked. Will also validate the post-merge smoke test looks good.

@brookesargent brookesargent marked this pull request as ready for review April 8, 2024 13:42
@brookesargent brookesargent requested a review from a team as a code owner April 8, 2024 13:42
@brookesargent brookesargent changed the title don't use ::set-output chore: don't use ::set-output Apr 8, 2024
Copy link
Contributor

@jharley jharley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹✨

@brookesargent brookesargent merged commit ef437f8 into main Apr 8, 2024
11 checks passed
@brookesargent brookesargent deleted the brooke.set-output branch April 8, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The set-output command is deprecated and will be disabled soon
3 participants