Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add landing page attributes #25

Closed
ahrbnsn opened this issue Jan 19, 2024 · 0 comments · Fixed by #30
Closed

Add landing page attributes #25

ahrbnsn opened this issue Jan 19, 2024 · 0 comments · Fixed by #30
Assignees
@ahrbnsn
Labels
type: enhancement New feature or request

Comments

@ahrbnsn
Copy link
Contributor

ahrbnsn commented Jan 19, 2024 •
edited
Loading

As a follow-up to #10, create a new resource with information about the page's initial url:

  • full url

as well the individual bits of the url broken out into individual fields:

  • search params
  • hash
  • page
  • hostname
@ahrbnsn ahrbnsn added the type: enhancement New feature or request label Jan 19, 2024
@ahrbnsn ahrbnsn self-assigned this Jan 19, 2024
@ahrbnsn ahrbnsn mentioned this issue Jan 23, 2024
Merged
ahrbnsn added a commit that referenced this issue Jan 25, 2024
@ahrbnsn
feat: ✨ add entry page attributes to resource (#30)
cb678a0 
## Which problem is this PR solving?
- Closes #25 

## Short description of the changes
Adds  the following fields to the resource:
`entry_page.url` 
`entry_page.path` 
`entry_page.search` 
`entry_page.hash` 
`entry_page.hostname`

## How to verify that this has the expected result
Confirm the new fields are sent to honeycomb, and accurately reflect the
initial page location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahrbnsn ahrbnsn

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: ✨ add entry page attributes to resource honeycombio/honeycomb-opentelemetry-web
1 participant
@ahrbnsn