feat: add semantic browser resource fields & honeycomb distro info #23
Conversation
| @@ -42,6 +41,8 @@ import { | |||
| import { SemanticResourceAttributes } from '@opentelemetry/semantic-conventions'; | |||
| import { WebSDKConfiguration } from './types'; | |||
| import { SessionIdSpanProcessor } from './session-id-span-processor'; | |||
| import { browserDetector } from '@opentelemetry/opentelemetry-browser-detector'; | |||
There was a problem hiding this comment.
this puts the useragent in a browser.user_agent field instead of the documented browser.user_agent.original field — should we open an upstream PR to adjust, or fork the package?
There was a problem hiding this comment.
We should flag this upstream! In the meantime, when we do anything with this field in Honeycomb we should support both.
There was a problem hiding this comment.
FWIW this is already being investigated upstream as all of the semantic conventions are out of date. I would agree though that we should support both.
src/version.ts
Outdated
| @@ -0,0 +1 @@ | |||
| export const VERSION = '0.0.11'; | |||
There was a problem hiding this comment.
at $PREV_JOB we had a build step that automatically bumped the version number when publishing a package, so i went with that but unsure if that's how we want to roll
There was a problem hiding this comment.
Yep that works! We'll need this for the release process 💯 . Curious where we've got 0.0.11 from?
There was a problem hiding this comment.
the deranged vapors of my mind seeing 0.0.1 & reading 0.0.10 — i'll update to 0.0.2?
| @@ -42,6 +41,8 @@ import { | |||
| import { SemanticResourceAttributes } from '@opentelemetry/semantic-conventions'; | |||
| import { WebSDKConfiguration } from './types'; | |||
| import { SessionIdSpanProcessor } from './session-id-span-processor'; | |||
| import { browserDetector } from '@opentelemetry/opentelemetry-browser-detector'; | |||
There was a problem hiding this comment.
We should flag this upstream! In the meantime, when we do anything with this field in Honeycomb we should support both.
src/version.ts
Outdated
| @@ -0,0 +1 @@ | |||
| export const VERSION = '0.0.11'; | |||
There was a problem hiding this comment.
Yep that works! We'll need this for the release process 💯 . Curious where we've got 0.0.11 from?
ahrbnsn
force-pushed
the
ahr/browser-resource-attributes
branch
from
409b752
to
24ec8a5
Compare
|
my editor has a plugin that's doing some autoformatting on the markdown tables that is just havoc - removing my changes to the readme so i can merge this PR. will do a followup w/ readme update once i track down the culprit and disable it |
Which problem is this PR solving?
Short description of the changes
Swaps out the
browserDetectionexport from@opentelemetry/resources, replaces it with the one provided by@opentelemetry/opentelemetry-browser-detectorHow to verify that this has the expected result
Run the example app. For maximum fields, use a Chromium browser. In honeycomb, queries for the new fields should show your events:
browser.platform: Chromium onlybrowser.brands: Chromium onlybrowser.mobile: Chromium onlybrowser.languagebrowser.user_agent: note: this doesn't match the otel semantic conventions ofbrowser.user_agent.originalhoneycomb.distro.version: expected value:0.0.11honeycomb.distro.runtime_version: expected valuebrowser