fix: pass bytes.Reader to http.Request, clean up pooledReader ourselves #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianwilkes
reviewed
Jan 4, 2022
transmission/transmission.go
Outdated
Comment on lines
390
to
394
| if reader, ok := reqBody.(*pooledReader); ok { | ||
| req, err = http.NewRequest("POST", url.String(), &reader.Reader) | ||
| } else { | ||
| req, err = http.NewRequest("POST", url.String(), reqBody) | ||
| } |
There was a problem hiding this comment.
Why is this type switch necessary? You shouldn't need to pass the embedded Reader directly.
There was a problem hiding this comment.
because of https://go.dev/play/p/mNGgU5JkY1G sob
ianwilkes
approved these changes
Jan 4, 2022
lizthegrey
added
merge at will
|
Leaving this for @MikeGoldsmith to pick up in his morning once he wakes up in about 12 hours! |
MikeGoldsmith
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes
bytes.Readerdirectly tohttp.Requestto simplify logic and reduce likelihood of problems. Solves bug: log spam with GOAWAY errors; txmit not retried on GOAWAY #158 and bug: nil pointer dereference with Go 1.17.5 #154 more cleanly than fix: don't crash on stream aborts, always add content length #156 did.