Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go] drop support for go before 1.14 #164

Merged
merged 6 commits into from
Jan 26, 2022
Merged

[go] drop support for go before 1.14 #164

merged 6 commits into from
Jan 26, 2022

Conversation

lizthegrey
Copy link
Member

at this point anyone using go 1.14 is using something from before the pandemic :)

at this point anyone using go 1.14 is using something from before the pandemic :)
@vreynolds vreynolds added the version: bump major A PR that breaks backwards compatibility. label Jan 25, 2022
Copy link
Contributor

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lizthegrey ! If we can adjust this to only drop through 1.13, and keep support starting at 1.14 instead of 1.15, we'll be matched with the beeline and can avoid a major bump there for now. Then when we're ready to drop further we can drop in both places.

@lizthegrey lizthegrey changed the title [go] drop support for 1.12 through 1.14 [go] drop support for go before 1.14 Jan 26, 2022
@JamieDanielson JamieDanielson self-assigned this Jan 26, 2022
these will get updated when next release is published
to drop support for < go 1.13
Copy link
Contributor

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just a note, I dropped the changes from this PR for CHANGELOG and README because we'll add those in when we publish the new release.

@lizthegrey lizthegrey merged commit 386b9d2 into main Jan 26, 2022
@lizthegrey lizthegrey deleted the lizf.drop-older-go branch January 26, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: bump major A PR that breaks backwards compatibility.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants