refactor(utils/basic-auth): Moved Internal function to utils #3359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusukebe
reviewed
Sep 2, 2024
src/utils/basic-auth.ts
Outdated
| const USER_PASS_REGEXP = /^([^:]*):(.*)$/ | ||
| const utf8Decoder = new TextDecoder() | ||
|
|
||
| export type Auth = (req: HonoRequest) => { username: string; password: string } | undefined |
There was a problem hiding this comment.
I prefer making req as Request not HonoRequest. The utility function should be more general. So, HonoRequest that depends on Hono is not good.
There was a problem hiding this comment.
Thank you for the review.
I have removed the dependency on HonoRequest.
989a0db
|
Hi @sugar-cat7 Thank you for the PR(this is your first PR for |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3359 +/- ##
==========================================
+ Coverage 95.76% 95.77% +0.01%
==========================================
Files 151 152 +1
Lines 9186 9187 +1
Branches 2708 2699 -9
==========================================
+ Hits 8797 8799 +2
+ Misses 389 388 -1 ☔ View full report in Codecov by Sentry. |
|
Thank you! I'm merging it. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have moved the functions used internally in the Basic Auth Middleware to the utils directory. Additionally, I have added tests.
For the background on this refactor, please refer to the following: honojs/middleware#676 (comment)
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code