Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to absolute path. Tested on Bun. #3383

Closed

Conversation

cj-1010-1414
Copy link

@cj-1010-1414 cj-1010-1414 commented Sep 4, 2024

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@yusukebe
Copy link
Member

yusukebe commented Sep 5, 2024

Hi @cj-1010-1414

It is not a bug that the serve static does not support an absolute path. It's intended. Regarding supporting the absolute path, we are considering how we should support it. Either way, this will affect current user who uses this feature as a breaking change.

@cj-1010-1414
Copy link
Author

Hope soon Hono support both relative and absolute path

@yusukebe
Copy link
Member

yusukebe commented Sep 6, 2024

@cj-1010-1414

Okay. I'll work on it after releasing the next minor version.

@yusukebe
Copy link
Member

This feature is implemented in #3420. Thanks!

@yusukebe yusukebe closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants