Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(serve-static): performance optimization for precompressed feature #3414

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

usualoma
Copy link
Member

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.78%. Comparing base (5f78e4e) to head (9aeb1cd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3414   +/-   ##
=======================================
  Coverage   95.77%   95.78%           
=======================================
  Files         154      155    +1     
  Lines        9312     9314    +2     
  Branches     2730     2741   +11     
=======================================
+ Hits         8919     8921    +2     
  Misses        393      393           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning to create utils/constants.ts to have all constants in the honojs/hono project, which may include this COMPRESSIBLE_CONTENT_TYPE_REGEX. But it's not fixed yet. It's okay to create utils/compress.ts.

@yusukebe
Copy link
Member

@usualoma

Thanks! Perfect. I'll merge it now.

@yusukebe yusukebe merged commit 0edb243 into honojs:main Sep 16, 2024
14 checks passed
@usualoma usualoma deleted the perf-serve-static-precompressed branch September 16, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants